Rcip recenter #150
Merged
Rcip recenter #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There seems to be a bug in rcipTest where the vert passed to chnk.rcip.Rcompchunk is not the vertex obtained by interpolation. |
Member
Author
|
i think re-centering exactly at the vertex is the correct thing to do. we can think of the subtraction of the left end point as a sort of extra snapping done within Rcompchunk (I'm not actually sure that that step does anything, if we think about what the other matrix does to the points...) |
Removed commented-out code related to 'vert0' adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes rcip to recenter exactly at a vertex, which seems safer when it comes to things like fins and axissym. open to discussion