README: fastapi vs fastapi-startkit comparison#7
Merged
Conversation
Cover overview, correctness (both pass route_spec.rb 6/6), setup/deps (fastapi-startkit[fastapi]==0.46.0 pinned, same .Dockerfile.uvicorn default engine), and performance. Performance cites the Benchmark Runner's controlled same-host relative comparison verbatim (explicitly not official figures) with the macOS benchmarking caveat; no fabricated absolute numbers.
… baseline Committed benchmark matches the measured stack, so drop the version-mismatch disclosure and mark the comparison apples-to-apples. Attribute the POST /user overhead to FastAPI 0.139's include_router keeping a nested _IncludedRouter (intended behavior, reproducible in plain FastAPI), not startkit per-request code.
Add the upstream FastAPI reference next to the POST /user attribution; framed as the acknowledged include_router performance discussion that motivated the 0.139 _IncludedRouter design, not as a per-request measurement.
…al claim Cite the-benchmarker#5343 as a related include_router perf discussion (construction-time) and explicitly distinguish it from the per-request _IncludedRouter mechanism, rather than asserting it motivated the 0.139 redesign (unverified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a FastAPI vs FastAPI-StartKit comparison section to the README.
Contents
.spec/route_spec.rb6/6 (also confirmed in-container, immune to host-networking artifacts).fastapi-startkit[fastapi]==0.46.0(pinned in PR Pin fastapi_startkit benchmark to fastapi-startkit==0.46.0 #4) vsfastapi>=0.139,<0.140; both built from the same default.Dockerfile.uvicornengine; Python 3.13.On accuracy
--disable-keepalivefigures weren't obtainable on macOS (ephemeral-port /TIME_WAITexhaustion) — that caveat is stated.POST /usershows ~17–19% framework overhead at c64/c256.