Skip to content

Comments

🌐 Fix Chinese translation code snippet mismatch in Tutorial - Python Types Intro#2573

Merged
tiangolo merged 1 commit intofastapi:masterfrom
BoYanZh:patch-1
Jul 2, 2021
Merged

🌐 Fix Chinese translation code snippet mismatch in Tutorial - Python Types Intro#2573
tiangolo merged 1 commit intofastapi:masterfrom
BoYanZh:patch-1

Conversation

@BoYanZh
Copy link
Contributor

@BoYanZh BoYanZh commented Dec 27, 2020

By the way, it seems that the Optional part for python types is missing in the translation.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #2573 (28b65fb) into master (5614b94) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5614b94...28b65fb. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 28b65fb at: https://5fe8bb68a3b5c8f7087dfe6d--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-zh Chinese translations labels Jan 5, 2021
@tiangolo tiangolo changed the title Fix Chinese translation code snippet mismatch in Tutorial - Python Types Intro 🌐 Fix Chinese translation code snippet mismatch in Tutorial - Python Types Intro Jul 2, 2021
@tiangolo
Copy link
Member

tiangolo commented Jul 2, 2021

Thanks for your contribution @BoYanZh ! 🙇

And thanks for the reviews @Zxilly and @Laineyzhang55 ! 🍰

@tiangolo tiangolo merged commit a0b2006 into fastapi:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-zh Chinese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants