Remove unused OptionHelpExtra TypedDict from vendored _click?

[Vinv-AI]

First Check

• I added a very descriptive title here.
• I used the GitHub search to find a similar question and didn't find it.
• I searched the documentation, with the integrated search.
• I already searched in Google "How to X" and didn't find any information.
• I already read and followed all the tutorials in the docs and didn't find an answer.

Example Code

# In a fresh clone of fastapi/typer @ master:

# 1. OptionHelpExtra is defined but referenced nowhere else:
grep -rn "OptionHelpExtra" typer/
#   typer/_click/types.py:...:class OptionHelpExtra(TypedDict, total=False):
#   (only the definition site)

# 2. The method it annotates in upstream Click does not exist in the vendored copy:
grep -rn "get_help_extra" typer/
#   (no matches)

# 3. It is not re-exported from any public surface:
grep -rn "OptionHelpExtra" typer/__init__.py typer/_click/__init__.py
#   (no matches; no __all__ lists it)

# 4. TypedDict is imported solely for this type:
grep -rn "TypedDict" typer/
#   typer/_click/types.py:...:    TypedDict,
#   typer/_click/types.py:...:class OptionHelpExtra(TypedDict, total=False):

Description

OptionHelpExtra in typer/_click/types.py is a TypedDict vendored from Click 8.3.1, where it annotates the return of Option.get_help_extra(). Typer's vendored _click never included that method, and Typer's help-record assembly in typer/core.py doesn't use the type. It's referenced nowhere in the codebase and isn't part of any public API (private _click package, not re-exported, no all entry).

I'd like to remove OptionHelpExtra and its now-unused TypedDict import — no runtime or public-API change. Would you be open to a small PR for this? (If Typer later re-vendors Click's get_help_extra() path, the type can be reintroduced with its caller.)

Operating System

Windows

Operating System Details

Windows 10 (verification also reproduces on any OS — this is a static/source-only observation).

Project Version

0.27.1 (also present on current master, base commit 9a7b2e8)

Python Version

3.11.4

Additional Context

The removal was surfaced by an automated dead-code scan and manually verified with the grep checks above. AI-tooling details will be disclosed on the PR itself per the PR template's AI Disclaimer section

[phalberg]

Currently I think a lot is subject to change from the vendored version of Click, hinted from the maintainers, so not sure if they will handle this one differently:

• Bulding an own version
• Trying to maintain it somehow
• or just remove it

I think some work is already planned ahead here, but that is at least how I see it from my perspective.
Nonetheless good to point it out!

[svlandeg]

Hi @Vinv-AI! Thanks for the note. Everything in typer/_click is currently being refactored, we're working on this internally. Specifically, the entire typer/_click/types.py module will be removed once #1831 is merged.