🐛 Fix showing fast button as external link in animated terminals in docs - #1912
Conversation
📝 Docs previewLast commit ef44dbe at: https://329fca15.typertiangolo.pages.dev Modified Pages |
|
To have same functionality as a button we want a hover:
|
|
Ready from my side, the solution seems to have fixed the major problems! NoteThese "elements" |
@phalberg, have you evaluated how mush changes would introduce turning them into real buttons? |
Hey @YuriiMotov, thanks for asking. I haven’t evaluated the full impact of that change yet, but I can take a closer look and see if there are side-effects, etc then report back with what I find. |
That would be great! Thanks! |
No worries! |
Hey again @YuriiMotov. |
fast button as external link in animated terminals in docs
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM!
Suggested a couple of improvements
Thank you for great suggestions along the way and good help! |
tiangolo
left a comment
There was a problem hiding this comment.
Awesome, thank you! 🚀
And thanks @YuriiMotov for all the help. 🙌
Pull Request
Discussion: #1908
Description
Problem
fastandrestartwere marked as hyperlinks, it seems that under first initial load the page would render them as true hyperlinks, adding an icon that indicates to users that it will open a new tab and also not adhering to its styling (which is rather to the top right).Read more on the discussion page for details.
Solution
Note on small UI issues:
- Upon scolling down to the bottom of the page, then clicking(I can't reproduce this after 09ede97)faston a terminal widget, the content-side-bar overlaps the bottom content - slightly (if the side-bar is long enough).AI Disclaimer
I used ChatGPT 5.5 (High) to help investigate the issue. The final solution was determined and implemented manually.
Checklist