refactor(IO): clean up ffAppendFDBuffer - #671
Merged
Merged
Conversation
for 2 reasons: - Simplify the Code. - ffAppendFDBuffer can't make assumptions about how the read data will be processed, so the trim calls are inappropriate.
Contributor
Author
|
Comment out that ffStrbufEnsureFixedLengthFree will take care of NUL. |
Member
|
I think you are correct. Thanks |
Member
|
Maybe need some fixes @apocelipes |
CarterLi
added a commit
that referenced
this pull request
Dec 22, 2023
Member
|
It turns out that there are so many trailing line endings in sysfs. I fixed some of them, but surely not all. Although the change is right, it can be too dangerous. |
Contributor
Author
|
Yes. There are 40+ calls need to be checked. Maybe we should bring trims back and add a todo: "remove this after all check finished". |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for 2 reasons: