fix: support cookie v2.x#297
Merged
Merged
Conversation
Tony133
marked this pull request as ready for review
July 9, 2026 07:59
climba03003
approved these changes
Jul 9, 2026
Member
Member
Member
|
Ok, but I'm not talking about CI green/red, but about support: now the If the CI turns read, it means users will have red CIs as well and we will need to:
We will handle in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposal:
cookieto work withcookie v2.x.cookiev2 removed theparse(str, opts)export. Three test files (touch.test.js,path.test.js,delete.test.js) usedcookie.parse()on aSet-Cookieresponse header as an informal way to inspect its attributes, which threwcookie.parse is not a function(3 failing tests, see here: https://github.com/fastify/fastify-secure-session/actions/runs/28617250962/job/84864018405?pr=296#step:5:74).Note: