fix: normalize method in findRoute - #6838
Merged
climba03003 merged 1 commit intoJul 11, 2026
Merged
Conversation
climba03003
previously approved these changes
Jul 8, 2026
Ram-blip
force-pushed
the
fix-findroute-method-normalization
branch
from
July 8, 2026 16:09
6834bb1 to
37e41ea
Compare
climba03003
approved these changes
Jul 8, 2026
ilteoood
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
findRoute()was passing the provided method directly to the router lookup. Because registered route methods are normalized, a lookup likefindRoute({ method: 'get', ... })returnednulleven when the matchingGETroute existed.This change normalizes the method in
findRoute(), matching the existing behavior inhasRoute().Changes proposed:
lib/route.jsto normalize the method before callingrouter.find()test/find-route.test.jsfor lowercase method lookupVerification
node --test test/find-route.test.jsnode --test test/has-route.test.jsnpm testChecklist
npm run test && npm run benchmark --if-presentand the Code of conduct