Skip to content

Improve device names in screenshots documentation#919

Merged
janpio merged 1 commit intofastlane:masterfrom
tedgonzalez:snapshot/documentation
Apr 11, 2020
Merged

Improve device names in screenshots documentation#919
janpio merged 1 commit intofastlane:masterfrom
tedgonzalez:snapshot/documentation

Conversation

@tedgonzalez
Copy link
Copy Markdown
Contributor

Fixes #845

This is the full list I got when running

instruments -s devices

on a mac with Xcode 11.3.1, 10.2.1, 11.1, 11

Apple TV 4K (13.3) 
Apple TV 4K (at 1080p) (13.3) 
Apple Watch Series 4 - 40mm (6.1.1) 
Apple Watch Series 4 - 44mm (6.1.1) 
iPad (5th generation) (10.3.1) 
iPad (5th generation) (11.4) 
iPad (6th generation) (11.4) 
iPad (7th generation) (13.3) 
iPad Air (10.3.1) 
iPad Air (11.4) 
iPad Air (3rd generation) (13.3) 
iPad Air 2 (10.3.1) 
iPad Air 2 (11.4) 
iPad Pro (10.5-inch) (10.3.1) 
iPad Pro (10.5-inch) (11.4) 
iPad Pro (11-inch) (13.3) 
iPad Pro (12.9 inch) (10.3.1) 
iPad Pro (12.9-inch) (11.4) 
iPad Pro (12.9-inch) (2nd generation) (10.3.1) 
iPad Pro (12.9-inch) (2nd generation) (11.4) 
iPad Pro (12.9-inch) (3rd generation) (13.3) 
iPad Pro (9.7 inch) (10.3.1) 
iPad Pro (9.7-inch) (11.4) 
iPad Pro (9.7-inch) (13.3) 
iPhone 11 (13.3) 
iPhone 11 Pro (13.3) 
iPhone 11 Pro (13.3) + Apple Watch Series 5 - 40mm (6.1.1) 
iPhone 11 Pro Max (13.3) 
iPhone 11 Pro Max (13.3) + Apple Watch Series 5 - 44mm (6.1.1) 
iPhone 5 (10.3.1) 
iPhone 5s (10.3.1) 
iPhone 5s (11.4) 
iPhone 6 (10.3.1) 
iPhone 6 (11.4) 
iPhone 6 Plus (10.3.1) 
iPhone 6 Plus (11.4) 
iPhone 6s (10.3.1) 
iPhone 6s (11.4) 
iPhone 6s Plus (10.3.1) 
iPhone 6s Plus (11.4) 
iPhone 7 (10.3.1) 
iPhone 7 (11.4) 
iPhone 7 Plus (10.3.1) 
iPhone 7 Plus (11.4) 
iPhone 8 (11.4) 
iPhone 8 (13.3) 
iPhone 8 Plus (11.4) 
iPhone 8 Plus (13.3) 
iPhone SE (10.3.1) 
iPhone SE (11.4) 
iPhone X (11.4)```

@tedgonzalez tedgonzalez force-pushed the snapshot/documentation branch from 8a01d8f to b6c9107 Compare April 5, 2020 19:04
Copy link
Copy Markdown
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/snapshot is unfortunately auto generated and needs to be updated via https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/docs/capture_ios_screenshots.md

@tedgonzalez tedgonzalez force-pushed the snapshot/documentation branch from b6c9107 to f446f39 Compare April 11, 2020 14:16
@tedgonzalez
Copy link
Copy Markdown
Contributor Author

tedgonzalez commented Apr 11, 2020

Changes to actions/snapshot removed
Added to fastlane/fastlane#16292

Copy link
Copy Markdown
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@janpio janpio merged commit 0c221f8 into fastlane:master Apr 11, 2020
@tedgonzalez tedgonzalez deleted the snapshot/documentation branch April 12, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screenshot documentation has old device names

4 participants