Use unique name for hls4ml layer in pytorch extension api test #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vloncar
approved these changes
Apr 2, 2025
vloncar
approved these changes
Apr 2, 2025
laurilaatu
pushed a commit
to laurilaatu/hls4ml
that referenced
this pull request
May 20, 2025
…achinelearning#1255) * use unique name for hls4ml layer in pytorch extension api test * add annotation and update docs for pytorch extension API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pytests fail because the tests for the keras and pytorch extension APIs are run together use the same name for the hls4ml layer class that is added, resulting in
already registerederrors. Fixed by making the names unique in the pytorch case.Type of change
Tests
Pytests pass now
Checklist
pre-commiton the files I edited or added.