Add accumulator precision when plotting the model information #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GiuseppeDiGuglielmo Could you check the pre-commit failure reports and fix the issues? Applies to #1281 as well. |
|
@JanFSchulte I installed pre-commit and fixed a couple of errors. |
|
Thanks! From the screen shot it looks like the entries for the accum have a different font? I think it would be nicer if that would be unified. |
jmitrevs
reviewed
Apr 29, 2025
test/pytest/test_plot_model.py
Outdated
|
|
||
| def test_plot_model(convert): | ||
| # Test the plot_model function with a sample model. | ||
| output_file = "model_plot.png" |
There was a problem hiding this comment.
It's only minor, but hls4ml tends to use single quotes instead double quotes.
There was a problem hiding this comment.
I fixed the quotes and the italic font.
JanFSchulte
approved these changes
Apr 29, 2025
laurilaatu
pushed a commit
to laurilaatu/hls4ml
that referenced
this pull request
May 20, 2025
…chinelearning#1282) * Add accumulator precision when plotting the model information * Fix pre-commit flake8 errors * Replace double quotes with single quotes * Add both a MLP and CNN for the model plot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add accumulator precision when plotting the model information
Type of change
Tests
I provided a test in
test/pytest/test_plot_model.py.Checklist
pre-commiton the files I edited or added.