InABox: Check snapshot regions before creating box

[Davis-A]

When a snapshot is unavailable in the users datacentre it's much nicer to reply with a better response than "Something weird happened..."

[Davis-A]

The functionality is there. But i need to update the test suite before merging.

[Davis-A]

Tests fixed so i think this is good to go

[wolfsage]

nit: missing closing quote after '$region

Same below

[rjbs]

(yup)

[wolfsage]

Nice, though you aren't testing for the new error conditions? Would be nice to!

[rjbs]

You're going to have to change this when you rebase after the big test improvements, but it should be easy.

But also, I thing you've got more API requests than are needed for this? And testing the failure mode is probably a good idea, as Matthew said.

[rjbs]

This seems off to me. Above, with this line…

my $snapshot = await $self->_get_snapshot($version);

…it seems like we should have a snapshot already retrieved. Then, _get_snapshot_regions goes and fetches it again. Meanwhile, the API reference suggests that the objects returned from _get_snapshot should already have the region data. That would mean that this branch is adding another round trip and another place for things to fail.

Can you, instead, look at $snapshot->{regions} without making another request?

[Davis-A]

I am indeed an idiot. For some reason my brain decided that $snapshot was just an id, but clearly it's a hash because i'm getting the id from it 🤦

[rjbs]

If this is the worst mistake you make all week, you'll be doing great. 😄

[Davis-A]

Okie dokie. Re-done without my 🤦 error.

Also added tests for the snapshot check too.

adavis@carbon:~/src/Synergy$ yath t/inabox.t

** Defaulting to the 'test' command **

( PASSED )  job  1    t/inabox.t

                                Yath Result Summary
-----------------------------------------------------------------------------------
     File Count: 1
Assertion Count: 33
      Wall Time: 3.28 seconds
       CPU Time: 3.69 seconds (usr: 0.12s | sys: 0.04s | cusr: 2.99s | csys: 0.54s)
      CPU Usage: 112%
    -->  Result: PASSED  <--

[rjbs]

Love it.