Skip to content

Conversation

@FFTYYY
Copy link
Contributor

@FFTYYY FFTYYY commented Nov 9, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #106 into master will increase coverage by 0.82%.
The diff coverage is 96.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage    77.5%   78.33%   +0.82%     
==========================================
  Files          74       75       +1     
  Lines        3717     3873     +156     
==========================================
+ Hits         2881     3034     +153     
- Misses        836      839       +3
Impacted Files Coverage Δ
fastNLP/core/loss.py 90% <89.65%> (+17.27%) ⬆️
test/core/test_loss.py 99.15% <99.15%> (ø)
fastNLP/modules/encoder/variational_rnn.py 87.73% <0%> (-5.67%) ⬇️
fastNLP/fastnlp.py 92.19% <0%> (+1.41%) ⬆️
test/test_fastNLP.py 96.12% <0%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec58e3...3cadd5a. Read the comment docs.

Copy link
Member

@xuyige xuyige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the loss function names starts at line 99, loss.py should be more simpler
such as:
nll, cross_entropy, mse, ...

@xuyige xuyige merged commit abf840c into fastnlp:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants