fix(stt): notify when batch transcription completes#5300
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ComputelessComputer
force-pushed
the
fix/batch-completion-notification
branch
3 times, most recently
from
f50cb75 to
5a2943a
Compare
Show a desktop notification after successful batch transcription when the app window is hidden or unfocused.
ComputelessComputer
force-pushed
the
fix/batch-completion-notification
branch
from
5a2943a to
a9d5a5d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 00c9c28. Configure here.
* fix(stt): prompt before early browser auto-stop Keep auto-stop confirmation at five seconds and ask users before stopping browser meetings that drop well before the scheduled end. * fix(devtools): add auto-stop confirmation notification Add a devtools button that previews the meeting-ended auto-stop prompt and uses the active live session when available.
Use unique batch completion notification keys and recover session IDs from notification keys when sources are missing.
ComputelessComputer
force-pushed
the
fix/batch-completion-notification
branch
from
00c9c28 to
ce0e3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a desktop notification after successful batch transcription when the app window is hidden or unfocused.
Note
Medium Risk
Adds new desktop notifications and new notification event handling paths (including stopping active sessions and opening sessions from notification keys), plus extends the notification source interface across TS/Rust/Swift; mistakes could lead to incorrect session navigation or unintended stops.
Overview
Adds a desktop notification when batch transcription completes, gated on the app window being unfocused/hidden (with a
forceoverride) and using a fresh per-notification key that still encodes thesessionId.Extends notification handling so clicking notifications can directly open a specific session (via new
NotificationSource.sessionor by parsing batch-completion keys), and adds an auto-stop “meeting ended?” prompt flow where accepting the notification stops the matching active session.Refactors browser meeting auto-stop timing to use a single confirmation delay and introduces a scheduled-meeting early-end threshold that triggers the new prompt instead of auto-stopping. Adds a devtools Notifications panel to manually trigger these notifications, and updates Rust/Swift/TS notification source types plus tests for the new behaviors and key parsing/back-compat.
Reviewed by Cursor Bugbot for commit ce0e3b7. Bugbot is set up for automated code reviews on this repo. Configure here.