Skip to content

fix(stt): prompt before early browser auto-stop#5301

Merged
ComputelessComputer merged 2 commits into
fix/batch-completion-notificationfrom
fix/browser-meeting-auto-stop
May 22, 2026
Merged

fix(stt): prompt before early browser auto-stop#5301
ComputelessComputer merged 2 commits into
fix/batch-completion-notificationfrom
fix/browser-meeting-auto-stop

Conversation

@ComputelessComputer
Copy link
Copy Markdown
Collaborator

@ComputelessComputer ComputelessComputer commented May 22, 2026

Keep auto-stop confirmation at five seconds and ask users before stopping browser meetings that drop well before the scheduled end.


Note

Medium Risk
Changes auto-stop behavior for browser-triggered sessions and adds a notification-driven stop path, which could alter when recordings stop or continue if the new prompt logic misfires or notifications aren’t handled as expected.

Overview
Updates STT auto-stop for browser-based meetings to keep the 5s confirmation delay but prompt the user instead of auto-stopping when mic usage ends well before the scheduled calendar end (using a new AUTO_STOP_CALENDAR_EARLY_END_THRESHOLD_MS window).

Introduces a dedicated auto-stop notification key format (auto-stop-ended:), adds devtool support to trigger the prompt, and extends EventListeners to intercept these notifications so Accept stops the active session while Confirm/body clicks are ignored, with tests covering the new behavior.

Reviewed by Cursor Bugbot for commit c2af4cf. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2026

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 7948919
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a100bb4a16c530008d90f83

Comment thread apps/desktop/src/services/event-listeners.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/browser-meeting-auto-stop branch 2 times, most recently from 8d885e8 to 7948919 Compare May 22, 2026 07:54
@ComputelessComputer ComputelessComputer changed the base branch from main to fix/batch-completion-notification May 22, 2026 07:56
Comment thread apps/desktop/src/stt/contexts.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/batch-completion-notification branch from f50cb75 to 5a2943a Compare May 22, 2026 10:53
@ComputelessComputer ComputelessComputer force-pushed the fix/browser-meeting-auto-stop branch from 592c886 to 5acfdba Compare May 22, 2026 10:53
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5acfdba. Configure here.

Comment thread apps/desktop/src/services/event-listeners.tsx
Keep auto-stop confirmation at five seconds and ask users before stopping browser meetings that drop well before the scheduled end.
Add a devtools button that previews the meeting-ended auto-stop prompt and uses the active live session when available.
@ComputelessComputer ComputelessComputer force-pushed the fix/batch-completion-notification branch from 5a2943a to a9d5a5d Compare May 22, 2026 11:33
@ComputelessComputer ComputelessComputer force-pushed the fix/browser-meeting-auto-stop branch from 5acfdba to c2af4cf Compare May 22, 2026 11:33
@ComputelessComputer ComputelessComputer merged commit 6fb3957 into fix/batch-completion-notification May 22, 2026
6 checks passed
@ComputelessComputer ComputelessComputer deleted the fix/browser-meeting-auto-stop branch May 22, 2026 12:05
ComputelessComputer added a commit that referenced this pull request May 22, 2026
* fix(stt): prompt before early browser auto-stop

Keep auto-stop confirmation at five seconds and ask users before stopping browser meetings that drop well before the scheduled end.

* fix(devtools): add auto-stop confirmation notification

Add a devtools button that previews the meeting-ended auto-stop prompt and uses the active live session when available.
ComputelessComputer added a commit that referenced this pull request May 22, 2026
* fix(stt): notify when batch transcription completes

Show a desktop notification after successful batch transcription when the app window is hidden or unfocused.

* fix(stt): prompt before early browser auto-stop (#5301)

* fix(stt): prompt before early browser auto-stop

Keep auto-stop confirmation at five seconds and ask users before stopping browser meetings that drop well before the scheduled end.

* fix(devtools): add auto-stop confirmation notification

Add a devtools button that previews the meeting-ended auto-stop prompt and uses the active live session when available.

* fix(stt): stabilize batch completion notifications

Use unique batch completion notification keys and recover session IDs from notification keys when sources are missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant