Keep settings controls visible in a narrow window - #7269
Merged
Conversation
The 700px settings min-width was applied to the content panel beside the sidebar. min(700px, 100%) still resolved to 700px because 100% included the sidebar, so toggles and dropdowns were clipped on the right. Let that panel shrink, and allow setting rows to fit the remaining width. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
marked this pull request as ready for review
September 3, 2026 02:45
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: Settings toggles and dropdowns were clipped by the right window edge. Yesterday’s
min(700px, 100%)cap still resolved to 700px on the content panel because100%is the full sidebar+content group, so a typical ~900px window with a 200px sidebar overflowed by tens of pixels andoverflow-hiddenhid the controls.Fix: Stop forcing a 700px min-width on the inner settings content panel (it already grows with
flex-1). Keep the outer 900px preference, capped at the window. Let setting rows and the shared content wrapper shrink so right-aligned switches and selects stay on-screen.Verification
pnpm exec dprint fmtanddprint checkon the changed filespnpm exec oxlint --quiet --format=github apps/desktop/src/pnpm -F desktop typecheckpnpm -F desktop test(3729 passed)