style(footer): update layout and link styles for improved readability#2039
style(footer): update layout and link styles for improved readability#2039ComputelessComputer merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded@ComputelessComputer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFooter component restructured from two-column grid layout to responsive flex layout with left column expansion and right-side grid modification. Link styling updated to use dotted decoration with solid on hover. New "Tools" section added containing "Audio Transcription" and "OSS Navigator". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/components/footer.tsx (1)
4-8: Dead code: both branches return the same value.The
getMaxWidthClassfunction returns"max-w-6xl"regardless of the condition, making the conditional logic unnecessary.Apply this diff to simplify:
-function getMaxWidthClass(pathname: string): string { - const isBlogOrDocs = - pathname.startsWith("/blog") || pathname.startsWith("/docs"); - return isBlogOrDocs ? "max-w-6xl" : "max-w-6xl"; -} +function getMaxWidthClass(_pathname: string): string { + return "max-w-6xl"; +}Or remove it entirely and inline the value if this was intended to be a placeholder for future customization.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/src/components/footer.tsx(15 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, usecn(import from@hypr/utils). It is similar toclsx. Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/web/src/components/footer.tsx
🪛 GitHub Actions: web_ci
apps/web/src/components/footer.tsx
[error] 229-229: Command 'pnpm -F @hypr/web build && tsc --project tsconfig.json --noEmit' failed with TypeScript error TS2741: Property 'search' is missing in type '{ children: string; to: "/file-transcription"; className: string; }' but required in type 'MakeRequiredSearchParams<RouterCore<Route<Register, any, "/", "/", string, "root", undefined, {}, RouterContext, AnyContext, AnyContext, {}, undefined, ...>>, string, "/file-transcription">'.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - hyprnote
- GitHub Check: Header rules - hyprnote
- GitHub Check: Pages changed - hyprnote
- GitHub Check: fmt
🔇 Additional comments (4)
apps/web/src/components/footer.tsx (4)
20-21: Verify responsive layout behavior across breakpoints.The layout change from a two-column grid to a flex layout with
lg:flex-1andlg:flex-rowlooks correct for creating a responsive footer. Ensure this renders as expected on mobile, tablet, and desktop viewports.
60-60: LGTM: Grid structure change aligns with new layout.The grid change from
grid-cols-2 sm:grid-cols-4togrid-cols-2 sm:grid-cols-3 lg:grid-cols-5correctly accommodates the new Tools section (5 columns total). Thelg:flex-shrink-0ensures the grid doesn't shrink in the flex container.
223-245: New Tools section expands footer functionality.The addition of the Tools section with Audio Transcription and OSS Navigator links enhances the footer's utility. The structure and styling are consistent with other sections.
229-229: The Link to "/file-transcription" is correct and does not require asearchparameter.The route definition shows that the
idsearch parameter is optional with a fallback toundefined:id: (search.id as string) || undefined. Since the parameter has a default value, the Link component can safely omit thesearchprop.Likely an incorrect or invalid review comment.
ComputelessComputer
force-pushed
the
style/footer-link-readability
branch
2 times, most recently
from
3275320 to
7315702
Compare
ComputelessComputer
force-pushed
the
style/footer-link-readability
branch
from
7315702 to
1234ccb
Compare
1 participant
No description provided.