Skip to content

ui/footer-remove-default-underlines#2082

Merged
ComputelessComputer merged 2 commits intomainfrom
ui/footer-remove-default-underlines
Dec 3, 2025
Merged

ui/footer-remove-default-underlines#2082
ComputelessComputer merged 2 commits intomainfrom
ui/footer-remove-default-underlines

Conversation

@ComputelessComputer
Copy link
Collaborator

No description provided.

Eliminate always-on underlines in apps/web/src/components/footer.tsx so links are not underlined by default and only show a dotted underline on hover. Replaced "underline decoration-dotted hover:decoration-solid" with "no-underline hover:underline hover:decoration-dotted" (and added no-underline to inline-flex link classes) across all footer links to improve visual cleanliness while retaining the dotted hover effect.
Make the "Get started" link in the footer consistently underlined with a solid decoration. This change replaces the previous hover-only dotted underline behavior and ensures the link is visibly underlined by default for better affordance and accessibility.
@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit c417575
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/692f958f2eb2130008eae509
😎 Deploy Preview https://deploy-preview-2082--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit c417575
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/692f958f32946800082b42e2
😎 Deploy Preview https://deploy-preview-2082--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

📝 Walkthrough

Walkthrough

This pull request updates CSS class combinations in the footer component to apply underline styling on hover rather than persistently. Most links transition from permanent underlines with dotted decoration to no-underline defaults with hover-triggered underlines, while maintaining hover decoration styling.

Changes

Cohort / File(s) Change Summary
Footer link styling
apps/web/src/components/footer.tsx
Modified Tailwind CSS classes on footer links to change underline behavior from persistent to hover-based. Most links updated from underline decoration-dotted to no-underline hover:underline hover:decoration-dotted. One link (Get started) changed from underline decoration-dotted hover:decoration-solid to underline decoration-solid. Updates applied across navigation, company, social, and miscellaneous link sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Repetitive, mechanical CSS class replacements across a single file with a consistent pattern reduce cognitive load
  • Visual verification of styling changes required across multiple link sections

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining the purpose and rationale for the footer underline styling changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing default underlines from footer links and switching to hover-based underlines.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ui/footer-remove-default-underlines

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/web/src/components/footer.tsx (2)

34-39: Confirm intentional always-underlined styling for “Get started” CTA

This link keeps a permanent underline decoration-solid while the rest of the footer moves to hover-only underlines. If the goal is footer-wide consistency (no underline by default), consider aligning this CTA with the new no-underline hover:underline pattern; otherwise, this special case is fine but worth confirming as a deliberate design choice.


42-56: Consider extracting a shared “footer link” style to reduce duplication

Most links now share the same long Tailwind chain (text-sm text-neutral-600 hover:text-stone-600 transition-colors [inline-flex bits] no-underline hover:underline hover:decoration-dotted). This is good for visual consistency but quite repetitive.

Consider extracting a small helper (e.g., a const footerLinkBase = "..."; or a FooterLink component) so that future tweaks to hover/underline behavior are made in one place.

Also applies to: 67-80, 83-97, 99-118, 129-135, 137-155, 157-179, 189-227, 237-251, 262-315

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 779951b and c417575.

📒 Files selected for processing (1)
  • apps/web/src/components/footer.tsx (15 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, use cn (import from @hypr/utils). It is similar to clsx. Always pass an array and split by logical grouping.
Use motion/react instead of framer-motion.

Files:

  • apps/web/src/components/footer.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Redirect rules - hyprnote
  • GitHub Check: Header rules - hyprnote
  • GitHub Check: Pages changed - hyprnote
  • GitHub Check: fmt
  • GitHub Check: ci

@ComputelessComputer ComputelessComputer merged commit f4c37ad into main Dec 3, 2025
13 checks passed
@ComputelessComputer ComputelessComputer deleted the ui/footer-remove-default-underlines branch December 3, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant