ui/footer-remove-default-underlines#2082
Conversation
Eliminate always-on underlines in apps/web/src/components/footer.tsx so links are not underlined by default and only show a dotted underline on hover. Replaced "underline decoration-dotted hover:decoration-solid" with "no-underline hover:underline hover:decoration-dotted" (and added no-underline to inline-flex link classes) across all footer links to improve visual cleanliness while retaining the dotted hover effect.
Make the "Get started" link in the footer consistently underlined with a solid decoration. This change replaces the previous hover-only dotted underline behavior and ensures the link is visibly underlined by default for better affordance and accessibility.
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request updates CSS class combinations in the footer component to apply underline styling on hover rather than persistently. Most links transition from permanent underlines with dotted decoration to no-underline defaults with hover-triggered underlines, while maintaining hover decoration styling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/web/src/components/footer.tsx (2)
34-39: Confirm intentional always-underlined styling for “Get started” CTAThis link keeps a permanent
underline decoration-solidwhile the rest of the footer moves to hover-only underlines. If the goal is footer-wide consistency (no underline by default), consider aligning this CTA with the newno-underline hover:underlinepattern; otherwise, this special case is fine but worth confirming as a deliberate design choice.
42-56: Consider extracting a shared “footer link” style to reduce duplicationMost links now share the same long Tailwind chain (
text-sm text-neutral-600 hover:text-stone-600 transition-colors [inline-flex bits] no-underline hover:underline hover:decoration-dotted). This is good for visual consistency but quite repetitive.Consider extracting a small helper (e.g., a
const footerLinkBase = "...";or aFooterLinkcomponent) so that future tweaks to hover/underline behavior are made in one place.Also applies to: 67-80, 83-97, 99-118, 129-135, 137-155, 157-179, 189-227, 237-251, 262-315
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/src/components/footer.tsx(15 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Avoid creating a bunch of types/interfaces if they are not shared. Especially for function props, just inline them instead.
Never do manual state management for form/mutation. Use useForm (from tanstack-form) and useQuery/useMutation (from tanstack-query) instead for 99% of cases. Avoid patterns like setError.
If there are many classNames with conditional logic, usecn(import from@hypr/utils). It is similar toclsx. Always pass an array and split by logical grouping.
Usemotion/reactinstead offramer-motion.
Files:
apps/web/src/components/footer.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - hyprnote
- GitHub Check: Header rules - hyprnote
- GitHub Check: Pages changed - hyprnote
- GitHub Check: fmt
- GitHub Check: ci
No description provided.