Remove dead coffee-rails gem#82
Merged
Merged
Conversation
coffee-rails was dead: its only file, app/assets/javascripts/home.coffee, was the default Rails scaffold comment block (three comment lines, zero code). Converted that stub to an equivalent no-op home.js and dropped the gem; both Gemfile.lock and the dual-boot Gemfile.next.lock updated (also drops coffee-script / coffee-script-source). This was blocked under Sprockets 3.x (which registered a CoffeeScript engine unconditionally and required the coffee_script lib at precompile); the Sprockets 4 upgrade (#81) removed that coupling, so the gem is now cleanly removable. Verified locally: boots, assets:precompile succeeds (application.js incl. home.js, application.css, pdf.css), test suite green (16 runs, 52 assertions, 0 failures), rubocop clean (exact CI config), reek clean. System tests not run locally (no chromedriver in this env) — covered by CI; change is a no-op asset conversion so risk is minimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead
coffee-railsgem.Why
coffee-railswas unused: its only CoffeeScript file,app/assets/javascripts/home.coffee, was the default Rails scaffold comment block — three comment lines, zero code. Nothing else in the app is CoffeeScript.It couldn't be removed earlier: under Sprockets 3.x the CoffeeScript engine was registered unconditionally and
assets:precompilerequired thecoffee_scriptlib (whichcoffee-railsprovided), so dropping the gem broke asset compilation even with no real.coffeefiles. The Sprockets 4 upgrade (#81) removed that coupling, so the gem is now cleanly removable.Changes
home.coffee→home.js(identical comment-only content)gem "coffee-rails"from theGemfileGemfile.lockand the dual-bootGemfile.next.lock(also dropscoffee-script/coffee-script-source)Verification (local)
assets:precompilesucceeds —application.js(incl.home.js),application.css,pdf.cssrubocopclean (exact CI config.rubocop_with_todo.yml)reekclean (0 warnings)