Add ability to fetch next page with persisted query parameters#17
Merged
etagwerker merged 3 commits intofastruby:masterfrom Nov 17, 2018
Merged
Conversation
Contributor
|
@etagwerker @benphelps @mscottford can we get some response to this? Seems like a few PRs have stalled. |
Contributor
|
@etagwerker should we update this to master as the next PR to discuss? |
Member
|
@gap777 Yes, that's a good idea. Thanks! |
783b421 to
0964228
Compare
0964228 to
930a55e
Compare
Contributor
|
@etagwerker Rebased onto your master, but getting a test failure in I'm suspecting that's just an environmental issue, though. Can you try on your machine, and if all is well, merge? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting a new page of results (Not page 1), the query parameters are not persisted which leads to incorrect results. This PR intends to persist the initial query parameters that were correctly passed into the API request for the first page, along to the subsequent API requests for the rest of the pages of results.