add spec for user behaviour#34
Closed
chimedpalden wants to merge 1 commit intofastruby:masterfrom
chimedpalden:user-behavior-spec
Closed
add spec for user behaviour#34chimedpalden wants to merge 1 commit intofastruby:masterfrom chimedpalden:user-behavior-spec
chimedpalden wants to merge 1 commit intofastruby:masterfrom
chimedpalden:user-behavior-spec
Conversation
etagwerker
requested changes
Feb 6, 2019
Member
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@chimedpalden Looks good, just one comment 👍
|
|
||
| expect(users.entries.count).to eq(100) | ||
| expect(users.page).to eq(1) | ||
| users.send(:fetch_next_page) |
Member
There was a problem hiding this comment.
@chimedpalden I think it's best to not know so much about the implementation of the pagination logic...
Could you change this scenario to iterate through user.entries 115 times? That should do what you expect it to do.
Contributor
|
I'll pick this up |
Contributor
|
@cleicar are you going to work on this? |
Member
|
@bronzdoc @chimedpalden I just reviewed this again and it seems that #17 added coverage for this behavior. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.