Add support for SimpleCov 1.0 - #196
Merged
Merged
Conversation
mateusdeap
force-pushed
the
update-simplecov
branch
from
July 28, 2026 12:57
82bced4 to
56737b8
Compare
mateusdeap
changed the title
JuanVqz
approved these changes
Jul 28, 2026
JuanVqz
left a comment
JuanVqz
left a comment
Member
There was a problem hiding this comment.
Looks good!
For reference, here is what each CI job actually resolves to today, given the open-ended >= 0.17.1 floor:
| CI Ruby | simplecov resolved |
|---|---|
| 4.0, 3.4, 3.3, 3.2 | 1.0.x (needs Ruby >= 3.2) |
| 3.1, 3.0, 2.7, 2.6, 2.5 | 0.22.x |
| 2.4 | 0.18.x |
| 2.3 | 0.17.1 |
| spec.add_development_dependency "rake" | ||
| spec.add_development_dependency "rspec", "~> 3.0" | ||
| spec.add_development_dependency "simplecov", "~> 0.17.1" | ||
| spec.add_development_dependency "simplecov", ">= 0.17.1" |
Member
There was a problem hiding this comment.
Is it worth adding this or even being more strict?
Suggested change
| spec.add_development_dependency "simplecov", ">= 0.17.1" | |
| spec.add_development_dependency "simplecov", ">= 0.17.1", "< 2" |
Member
There was a problem hiding this comment.
Not actionable on our end, but v1 also deprecated the track_files in favor of cover just in case at some point we are required to switch to it, we can continue using track_files for our legacy Ruby's with:
SimpleCov.respond_to?(:cover) ? SimpleCov.cover("lib/**/*.rb") : SimpleCov.track_files("lib/**/*.rb")
Member
|
@mateusdeap, do we need a second pair of 👀, or are you good to merge? |
Member
Author
|
@JuanVqz Good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for simplecov 1.0 in development
Motivation and Context
Simplecov recently released it's 1.0.0 version and we want to make next_rails supports it.
How Has This Been Tested?
I simply ran all the specs and they all passed and a report was generated successfully.
I will abide by the code of conduct