Fix the undeclared rainbow require in the deprecations executable - #197
Merged
Conversation
exe/deprecations required rainbow, which the gemspec never declares as a runtime dependency, so the shipped executable raised LoadError on a clean install and only worked where rainbow happened to be present for another reason. v1.6.0 dropped the dependency for lib/ but the executable kept requiring it. The gem already has a dependency-free ANSI wrapper used throughout lib/. Add the underline style it was missing and switch the CLI to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
exe/deprecationsrequiresrainbow, which the gemspec never declares as a runtime dependency. v1.6.0 dropped that dependency in favor of the nativeNextRails::Tintwrapper (#183), but only forlib/; the executable kept itsrequire "rainbow".On a clean install the shipped executable raises
LoadErrorand no mode works at all. It only appears to work whererainbowhappens to be installed for some other reason, which is why it went unnoticed.Fix
Switch the CLI to
NextRails::Tint, the dependency-free ANSI wrapper already used throughoutlib/, and add theunderlinecode (4) it was missing, since the CLI headlines use it.Verification
With rainbow removed from the load path the CLI now loads and runs; before this change it aborted with
LoadError.