Allow rocksdb to accept read_only option in order to share tables among workers#331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 100 100
Lines 10903 10905 +2
Branches 1529 1529
=======================================
+ Hits 10295 10297 +2
Misses 533 533
Partials 75 75
Continue to review full report at Codecov.
|
patkivikram
left a comment
There was a problem hiding this comment.
Is this tested with https://github.com/faust-streaming/python-rocksdb? Thats the official rocksdb binding we are using for this project
|
I've been using https://github.com/NightTsarina/python-rocksdb with Faust. I made a PR for that update in faust-streaming/python-rocksdb#1 so that we can synchronize progress on all forks. Feel free to merge that whenever you feel comfortable. I just tested this PR with the current release of https://github.com/faust-streaming/python-rocksdb and I can confirm everything works properly. Before using the changes in this PR, I got errors such as It'd be nice if I could make the |
Closes #330, I've had success by running multiple Faust apps with the same data directory for RocksDB
I'd like to write some test cases/examples before merging this in order to understand how this works better. If this functionality is not intended, feel free to close this immediately.