Conversation
The .deb named the binary and icons after the Cargo crate (sink), so it installed /usr/bin/sink + sink.png even though the app is Inari. Rename the crate sink -> inari (lib sink_lib -> inari_lib) so bundles ship /usr/bin/inari and inari.png; point install.sh's BUILD_BIN at the new output name. Also make the release workflow bump the version in the dev branch it opens: after releasing vX.Y.Z it commits X.Y.(Z+1) to dev/X.Y.(Z+1), so merging that branch to main auto-releases the next version with no manual bump — handy for exercising the in-app updater. Version bumped to 1.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .deb named the binary and icons after the Cargo crate (sink), so it installed /usr/bin/sink + sink.png even though the app is Inari. Rename the crate sink -> inari (lib sink_lib -> inari_lib) so bundles ship /usr/bin/inari and inari.png; point install.sh's BUILD_BIN at the new output name.
Also make the release workflow bump the version in the dev branch it opens: after releasing vX.Y.Z it commits X.Y.(Z+1) to dev/X.Y.(Z+1), so merging that branch to main auto-releases the next version with no manual bump — handy for exercising the in-app updater.
Version bumped to 1.0.2.