fix: stamp watchdog liveness in every reply builder#7
Merged
Conversation
Same defect as feastorg/Slice_DCMT#9: only the GET_WATCHDOG reply builder stamped wdLastRxMs, so the controller's 1 Hz GET_STATE polls never fed the watchdog (SET_REPLY staging frames are excluded from on_message) and an armed idle board tripped 5 s after arming. Stamp in all reply builders per the design in #5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same defect and fix as feastorg/Slice_DCMT#9 (found live on the bench): poll traffic never fed the watchdog because only the GET_WATCHDOG reply builder stamped liveness; armed idle boards tripped 5 s after arming. Stamp in every reply builder per the #5 design. gen1_nano builds green.