Skip to content

✨ feat: allow user creation if keyId unique - #930

Merged
deleteLater merged 5 commits into
featbit:mainfrom
jeffrey-vang:create-end-useroptions
Jun 26, 2026
Merged

✨ feat: allow user creation if keyId unique#930
deleteLater merged 5 commits into
featbit:mainfrom
jeffrey-vang:create-end-useroptions

Conversation

@jeffrey-vang

Copy link
Copy Markdown
Contributor

Description

End users cannot be created if partial matches are returned when selecting individual flag targets. Changes allow for the Create option to be selected as long as the input is not a direct match with an existing end user.

Testing Instructions

  • Run cd modules/front-end && npm start
  • Create an end user 'Tester' via the feature flag individual targeting section. Save flag configuration.
  • Upon refresh, enter 'Test' in the feature flag individual targeting section. Create option should be present alongside the search dropdown of any existing end users partial matches.

Screenshots

Before

image

After

image

Related

#929

@deleteLater deleteLater self-assigned this Jun 26, 2026
@deleteLater deleteLater added the ui label Jun 26, 2026
@deleteLater deleteLater moved this to In Progress in FeatBit Jun 26, 2026
@deleteLater deleteLater changed the title 🐛 fix: allow end user creation if one does not already exist with keyId ✨ feat: allow user creation if keyId unique Jun 26, 2026
@deleteLater
deleteLater requested a review from Copilot June 26, 2026 11:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “Create end user” option behavior in the Individual Targeting user picker so that users can be created even when the search returns partial matches, as long as the entered keyId is not an exact match of an existing user.

Changes:

  • Updates the TargetUserComponent user list population to prepend a “Create: {searchValue}” option when there’s no exact keyId match.
  • Preserves existing search results while enabling creation from partial-match searches.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/front-end/src/app/core/components/target-user/target-user.component.ts Outdated
Comment thread modules/front-end/src/app/core/components/target-user/target-user.component.ts Outdated
deleteLater and others added 2 commits June 26, 2026 19:54
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread modules/front-end/src/app/core/components/target-user/target-user.component.ts Outdated
deleteLater and others added 2 commits June 26, 2026 20:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@deleteLater deleteLater left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deleteLater
deleteLater merged commit b8b89e9 into featbit:main Jun 26, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in FeatBit Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants