Create TargetMeanPredictor class to enhance SelectByTargetMeanPerformance - #358

Closed

Morgan-Sell wants to merge 157 commits into

feature-engine:mainfrom

Morgan-Sell:issue_296

Commits on Jan 15, 2022

add new folder

sana
authored and
Morgan-Sell
committed
599f496
create TargetMeanPredictor class and its outline
Morgan-Sell
committed
b4b0dae
built more of TargetMeanPredictor class framework
Morgan-Sell
committed
18a4840
add 3 init params
Morgan-Sell
committed
359a9c0
expand fit() method
Morgan-Sell
committed
1e48118
add discretisers to fit() method
Morgan-Sell
committed
ad9f095
add 'numeric_var_startegy' param and cleaned up init()
Morgan-Sell
committed
276ef04
create new init params
Morgan-Sell
committed
122520d
identify variable types
Morgan-Sell
committed
c137b7a
instatiate encoder and discretisers in fit()
Morgan-Sell
committed
befad12
instatiate and fit encoder and discretiser
Morgan-Sell
committed
da4af56
add init params and check
Morgan-Sell
committed
95409e4
create disc_mean_dict to store means for the bins of each numerical variable
Morgan-Sell
committed
526ac84
add checks in predict()
Morgan-Sell
committed
91dbfa6
create test_prediction directory and files
Morgan-Sell
committed
6643b0e
start creating first check
Morgan-Sell
committed
743ef44
create df_pred() in conftest.py
Morgan-Sell
committed
ceb30f3
create prediction init file and expand test_target_mean_predictor_fit()
Morgan-Sell
committed
2295a27
fix bugs
Morgan-Sell
committed
6a69106
fix bugs
Morgan-Sell
committed
ca5a754
create df_pred() to test TestMeanPredictor
Morgan-Sell
committed
e1ce27a
bug: KeyError:None when slicing df_pred even though all variables exists w/in df. sucessfully printed sliced df using column names
Morgan-Sell
committed
67adf9d
resolve bug in fit(). code pass initial part of test_target_mean_predictor_fit
Morgan-Sell
committed
09fd25a
add df checks and bins to the discretisers
Morgan-Sell
committed
cf94bfa
add fit params tests
Morgan-Sell
committed
4c9beea
add test for fit params
Morgan-Sell
committed
55a65fe
add test for fit params
Morgan-Sell
committed
cec9f70
create code for predict(). outstanding items to be discussed.
Morgan-Sell
committed
8ef5e28
add functionality in fit() if self.variables is None and rearrange 2 lines of code in fit()
Morgan-Sell
committed
ea9a852
create _make_categorical_pipeline()
Morgan-Sell
committed
196b248
create _make_numerical_pipeline()
Morgan-Sell
committed
9d9db4b
create _make_combine_pipeline()
Morgan-Sell
committed
8208e61
incorporate pipeline methods into fit()
Morgan-Sell
committed
e75d72d
incorporate pipeline methods into fit()
Morgan-Sell
committed
7ec6ebd
edit bins check in init method
Morgan-Sell
committed
36e189f
delete ignore_format param
Morgan-Sell
committed
6882726
delete ignore_format param
Morgan-Sell
committed
952f3d1
remove variables check in the beginning of fit()
Morgan-Sell
committed
1598671
clean fit() code
Morgan-Sell
committed
a0a4fd1
start refactoring predict()
Morgan-Sell
committed
585f73e
refactor fit() and predict()
Morgan-Sell
committed
15d22c3
update MeanEncoder instantiations
Morgan-Sell
committed
0686497
update fit params test
Morgan-Sell
committed
9967fcb
create conftest_prediction and move df_pred() from conftest to conftest_prediction
Morgan-Sell
committed
cf32be9
fix docstring
Morgan-Sell
committed
0345232
refactor file
Morgan-Sell
committed
85ae45e
complete predict()
Morgan-Sell
committed
5aeb558
create df_pred_small() in conftest
Morgan-Sell
committed
3a21dbe
refactor pipeline code
Morgan-Sell
committed
1e3e1c8
create test_target_mean_predictor_transformation()
Morgan-Sell
committed
4c54b4b
start creating r2_score and clean code
Morgan-Sell
committed
d3ad152
create mean_accuracy_score()
Morgan-Sell
committed
a6c3a09
edit df_pred_small()
Morgan-Sell
committed
dbf8270
refactor code
Morgan-Sell
committed
432a3fe
create test_r2_score_calculation_with_equal_distance()
Morgan-Sell
committed
29868a8
refactor code
Morgan-Sell
committed
c223c9d
add binary-label feature to df_pred and df_pred_small
Morgan-Sell
committed
482c7ff
fix styler errors"
Morgan-Sell
committed
cf68ec2
fix style errors
Morgan-Sell
committed
2d598f3
fix style errors
Morgan-Sell
committed
f050d27
fix style errors
Morgan-Sell
committed
fb9af35
fix style errors
Morgan-Sell
committed
f34e3f3
add 'regression=False' to DecisionTreeEncoder() in test_check_estimator_encoders.py
Morgan-Sell
committed
a44995f
coalesce r_squared_score() and mean_accuracy_score() to create score()
Morgan-Sell
committed
505e3b6
clean code
Morgan-Sell
committed
1edb969
add 'Height_cm' feature to dataframes
Morgan-Sell
committed
0bddbdb
add test_predictor_with_all_numerical_variables()
Morgan-Sell
committed
2581a48
clean code
Morgan-Sell
committed
2d1d93f
add new tests
Morgan-Sell
committed
acee844

Commits on Jan 16, 2022

Commits on Jan 17, 2022

create BaseTargetMeanPredictor class
Morgan-Sell
committed
ad878ea
add fit() and supporting methods to BaseTargetMeanPredictor class
Morgan-Sell
committed
b5f35ae
add init() and predict() to TargetMeanRegressor
Morgan-Sell
committed
c6cc730
expand BaseTargetMeanEstimator docstring
Morgan-Sell
committed
65832e1
expand docstrings
Morgan-Sell
committed
4d2cd2b
clean code
Morgan-Sell
committed
ae1c452
create TargetMeanClassifier class
Morgan-Sell
committed
666b853
revise precition __init__.py
Morgan-Sell
committed
39eec98
create predict_proba for TargetMeanClassifier
Morgan-Sell
committed
83f8b9a

Commits on Jan 18, 2022

change test_target_mean_prediction.py to test_target_mean_regressor.py
Morgan-Sell
committed
8a3c9b1
clean code on test_target_mean_prediction.py
Morgan-Sell
committed
d896e4c
resolve errors returned from test_target_mean_regressor.py
Morgan-Sell
committed
789c9f4
edit TargetMeanClassifier init
Morgan-Sell
committed
a1ea2c3
create TargetMeanClassifier class
Morgan-Sell
committed
f33dead
fix error
Morgan-Sell
committed
ca65364
changes wording init
solegalli
committed
a8d6c9f
refactors base perdictor, expands variable detection
solegalli
committed
4e4ff93
refactors target mean regressor
solegalli
committed
2664e95

Commits on Jan 19, 2022

finish refactoring code
solegalli
committed
9dc1cc6
final edits of docstrings
solegalli
committed
bbe8edb

Commits on Jan 24, 2022

Merge pull request #5 from feature-engine/mean_target_prediction
Morgan-Sell
authored
59b9f98
add numpy array check for y_pred in TargetMeanRegressor
Morgan-Sell
committed
9a17698
add 2d numpy array check for 'prob' in TargetMeanClassifier
Morgan-Sell
committed
ecbdcd1
edit warning string
Morgan-Sell
committed
ec356e5
add 2-column numpy array check for 'log_prob' in TargetMeanClassifier
Morgan-Sell
committed
adf70e3
add numpy check to TargetMeanClassifier predict()
Morgan-Sell
committed
9fdbe2c
create test_raises_error_when_wrong_input_params()
Morgan-Sell
committed
9d7a16b
create test_default_params()
Morgan-Sell
committed
6de2025
delete test_incorrect_strategy_during_instantiation()
Morgan-Sell
committed
bc02226
delete test_incorrect_bin_value_during_instantiation()
Morgan-Sell
committed
a4c4d0c
clean code in test_target_mean_regressor.py
Morgan-Sell
committed
64f860c
create test_raises_error_when_not_fitting_a_df() using mark.parametrize
Morgan-Sell
committed
7b2ee1a
create test_raises_error_when_not_transforming_a_df() and clean test code
Morgan-Sell
committed
04512f3
refactor code
Morgan-Sell
committed
10d970a

Commits on Jan 25, 2022

Commits on Jan 26, 2022

Commits on Jan 30, 2022

add typehint to _find_categorical_and_numerical_variables()
Morgan-Sell
committed
23a5b6c
fix _find_categorical_and_numerical_variables()
Morgan-Sell
committed
99bedb0
fix test_attributes_upon_fitting() error for regressor
Morgan-Sell
committed
0b27d97
fix test_attributes_upon_fitting() error for classifier
Morgan-Sell
committed
2fcc4b0
fix clsfr predict()
Morgan-Sell
committed
18e346d
create test_classifier_prediction_results_with_all_numerical_variables()
Morgan-Sell
committed
be703d8
edit df_pred_small
Morgan-Sell
committed
5235063
create test_classifier_results_with_all_categorical_variables()
Morgan-Sell
committed
ab671ec
create two clsfr tests
Morgan-Sell
committed
15d0e65
revise rgrsr test_raises_error_when_df_has_nan()
Morgan-Sell
committed
114d264
create clsfr test_error_if_df_contains_na_in_transform()
Morgan-Sell
committed
af3329b
create clsfr test_raises_error_when_not_fitting_a_df()
Morgan-Sell
committed
804fd3f
fix style errors
Morgan-Sell
committed
726c9a9
create 2 tests for test_variable_manipulation
Morgan-Sell
committed
a3d9e1a
add 1 test and refactor code
Morgan-Sell
committed
1bac7ea
create df_enc_categorical_and_numeric
Morgan-Sell
committed
2f8baf6
create test_find_cat_and_num_vars_df_contains_num_and_cat() for test_variable_manipulation
Morgan-Sell
committed
5301df7
create test for when user passes None, df contains numerical for test_variable_manipulation
Morgan-Sell
committed
d546feb
create test for when user passes None, df contains categorical for test_variable_manipulation
Morgan-Sell
committed
d1664a5
create test for user passes empty list, function raises error for test_variable_manipulation
Morgan-Sell
committed
730480e
create 3 tests for test_variable_manipulation
Morgan-Sell
committed
469aeb4
fix bug in _find_categorical_and_numerical_variables()
Morgan-Sell
committed
b34f94f
try to debut test_error_find_cat_and_num_vars_datetime_var()
Morgan-Sell
committed
a9a8f3f
rename unit tests
Morgan-Sell
committed
1682d22
fix style error
Morgan-Sell
committed
4cc0250

Commits on Feb 3, 2022

Commits on Feb 4, 2022

fix dataframe checks in BaseTargetMeanEstimator
Morgan-Sell
committed
8b99e66

Commits on Feb 5, 2022

revise dataframe checks. try sklearn check_X_y cause upstream errors b/c fcn returns numpy arrays which don't have dtypes
Morgan-Sell
committed
03922c3
clean code for BaseTargetMeanEstimator and TargetMeanClassifier
Morgan-Sell
committed
5c5ee77
change df_enc_categorical_and_numeric to df_vartypes
Morgan-Sell
committed
e6ea391
delete df_enc_categorical_and_numeric
Morgan-Sell
committed
57ea390
expand test_classifier_results_with_all_categorical_variables()
Morgan-Sell
committed
cf3e05d
update test_classifier_results_with_all_numerical_variables() and fix test_attributes_upon_fitting()
Morgan-Sell
committed
1be8a71
update test_regression_score_calculation_with_equal_frequency
Morgan-Sell
committed
7abb331
create test_regressor_with_two_variables()
Morgan-Sell
committed
58b6145
create 2 regressor tests
Morgan-Sell
committed
8330b0f
add 1 regressor test
Morgan-Sell
committed
9f610b7
fix TargetMeanClassifier fit()
Morgan-Sell
committed
d0e7040
create 2 tests for TargetMeanClassifier
Morgan-Sell
committed
2dde9e6
refactor classifier test code
Morgan-Sell
committed
74f8468
change 2 unit test names
Morgan-Sell
committed
d2364bf