Skip to content

Fix pytests - #363

Merged
solegalli merged 12 commits into
mainfrom
fix_pytests
Jan 31, 2022
Merged

Fix pytests#363
solegalli merged 12 commits into
mainfrom
fix_pytests

Conversation

@solegalli

@solegalli solegalli commented Jan 28, 2022

Copy link
Copy Markdown
Collaborator

Hi @gverbock

I isolated the fixes to the tests that are not passing and the reformatting of the recursive feature selectors into their own PR.

I short, I checked out the files that are relevant from #361 into a new branch: fix_pytest, made a few more code changes, and made this PR. The tests for the base recursive are finished and passing.

We should probably finish working on this PR first, merge to main, and then rebase main onto #361 to add the confirm_variables parameter here as well.

Created tests that should be performed on all transformers. Added those tests to the check_selectors test file.

TODO :

@solegalli
solegalli merged commit 8e61bb4 into main Jan 31, 2022
@solegalli
solegalli deleted the fix_pytests branch January 31, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant