add stacking selector functionality and docstrings - #369
Conversation
|
I think I brought all the changes in PR #361 to this one now. |
|
Hi @gverbock It would be great if you can pick up this changes in a new branch and then make a PR to the branch here, Also, since all classes have the functionality for |
|
Hi @solegalli
|
Hi @gverbock I am not sure why I did not receive a notification for your last message. I am really sorry I reply only today :_( I believe I have now added all the necessary changes. Needs a final review to merge. |
|
Still needs revision:
I think that will be all. |
* creates abstraction for confirm vars * adds docstrings for confirm vars * picks var manipulation and tests * minor edits to base_selector * adds docstring func to drop constant * adds docstring func to drop correlated * adds docstring func to drop duplicated * adds docstring func to drop high psi * adds spaces in docstrings drop features * adds docstring funct to all selectors * fixes most circle ci errors * adds test confirm_vars to drop constant selector * adds test confirm_vars to drop corr selector * adds test confirm_vars to drop dupes selector * adds test confirm_vars to drop high psi selector * fixes style * finishes pr * tox auto fixes * ignores flake8 in selector docstrings * changes wording of some dosctrings * final docstrings fixes * small change in recursive base * update wording confirm_variables * removes whitespace in sel docstrings * changes wording in selectors docstrings common file * final wording changes, removes unused docstring * add test confirm_variables when variables is None * role back test files to main
closes #361
closes #309
Hi @gverbock
I rebased main to solve the pytest errors and add docstring functionality and then cherry picked some of the changes in #361.
I still need to cherry-pick the test changes, and we need to add the confirm_variables functionality to the remaining selectors (except the target mean because we need to fix that in a different PR)