fixes cross-validation error when wrapping OneHotEncoder

[noahjgreen295]

Fix and unit test for issue 368

[solegalli]

Hi @noahjgreen295

The changes in the wrappers.py file and the additional test with the cv look great! Thank you so much for this.

We do need to remove all the other files from the PR though. The are not relevant for this PR.

Would you be able to do that?

To remove the additional files you need to do:

git checkout main -- path/to/the/file.py

If the tests fail, let me know. But they shouldn't.

[noahjgreen295]

0d2fabf

Hi @noahjgreen295

The changes in the wrappers.py file and the additional test with the cv look great! Thank you so much for this.

We do need to remove all the other files from the PR though. The are not relevant for this PR.

Would you be able to do that?

To remove the additional files you need to do:

git checkout main -- path/to/the/file.py

If the tests fail, let me know. But they shouldn't.

Hi Soledad,
Thanks - glad to help!
For the other files to remove, do you mean the ones that tox changed in this commit? If so, I can take care of that right away. Let me know - thanks!

[solegalli]

Yes. Those files :)

[noahjgreen295]

Yes. Those files :)

OK done in latest commit! Unit tests all passed.

[solegalli]

Thank you!

To pass the test we need to shorten this line of code:

tests/test_wrappers/test_sklearn_wrapper.py:333:89: E501 line too long (116 > 88 characters)

would you be able to do that?

if you do black tests/test_wrappers/test_sklearn_wrapper.py it should fix it. Otherwise, you can break it manually.

[noahjgreen295]

OK done in latest commit. It's strange that my CLI black didn't pick it up (I'm using v. 22.1.0.) That often happens with me at work with that tool (CI black has the issue, CLI black misses it.) Anyway, all committed!

[solegalli]

Thank you so much @noahjgreen295 !

Merging and closing as we speak :)

[noahjgreen295]

My pleasure, glad to help! And thank you for guiding me through the process. Happy to be involved with this great project.