adds WindowFeatures class - #398
Merged
Merged
Conversation
…ion error. dataframes do not reconcile.
…in_index, and test_sort_index to test_check_estimator_forecasting.py
solegalli
added a commit
that referenced
this pull request
Mar 29, 2022
* initial commit * create init and add params * started creating fit() * create init param tests * fix check bugs * fix text bugs * create fit() * fix fit() * update fit() * started coding transform() * create get_feature_names_out() * edit fit() * started creating test_get_feature_names_out * add to test_get_feature_names_out and fix bug in fit() * add function to init params * finish transform() * create tests for 'function' init param * delete extra transform() method * create test_correct_window_when_using_periods. Need to resolve assertion error. dataframes do not reconcile. * complete test_correct_window_when_using_periods() * create test_correct_window_when_using_freq * add np.sum to 'function' param * create test_sort_index * remove checks that are handled by pandas * initial commit of BaseForecaster class * move fit() to BaseForecast class * create transform() in BaseForecast class * remove redundant code from BaseForecast transform() * expand docstrings * clean code * add WindowFeatures to test_check_estimator_Forecasting * fix style errors * fix WindowFeature tests * move test_error_when_nan_in_index, test_error_when_not_unique_values_in_index, and test_sort_index to test_check_estimator_forecasting.py * removes base forecaster from init * modifies base forecasting class * edit docstrings base forecaster * migrates common functionaity to base_forecaster, and adjusts lag features class * shifts more common functionality to base forecaster * expands docstrings window features, starts modifying functionaity * expands window features functionality * final update to windows tests and other touches * fixes code style * modified docstrings * adds docs main files * renames class and methods * renamed script * changes wording in comments and fixes typos * minor fixes in window features * adds test for n_features_in_ * allows string input to functions parameter * finishes tests window features * fixes codestyle * finishes user documentation Co-authored-by: Morgan-Sell <morganpsell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #343
closes #380
@KishManani @Morgan-Sell
Creating a new PR to finish off this class as @Morgan-Sell is on holidays :)