Skip to content

fix inverse_transform in encoders - #539

Merged
solegalli merged 21 commits into
mainfrom
check_inversetransform
Oct 13, 2022
Merged

fix inverse_transform in encoders#539
solegalli merged 21 commits into
mainfrom
check_inversetransform

Conversation

@solegalli

@solegalli solegalli commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

In addition:

  • add functionality to encode unseen in ordinal encoder
  • change logic of encoding unseen categories
  • increase code coverage for encoders
  • remove CategoricalMixinExpanded
  • remove dictionary check in fit
  • add deprecation warning in PRatioEncoder

closes #428
closes #538

@solegalli solegalli linked an issue Oct 12, 2022 that may be closed by this pull request
@solegalli

Copy link
Copy Markdown
Collaborator Author

FYI @glevv

@solegalli solegalli linked an issue Oct 12, 2022 that may be closed by this pull request
@codecov

codecov Bot commented Oct 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #539 (ed35133) into main (93cb37b) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   96.84%   97.39%   +0.54%     
==========================================
  Files          88       88              
  Lines        3331     3336       +5     
  Branches      671      655      -16     
==========================================
+ Hits         3226     3249      +23     
+ Misses         45       32      -13     
+ Partials       60       55       -5     
Impacted Files Coverage Δ
feature_engine/encoding/base_encoder.py 98.59% <100.00%> (+11.57%) ⬆️
feature_engine/encoding/count_frequency.py 96.87% <100.00%> (-0.10%) ⬇️
feature_engine/encoding/decision_tree.py 96.07% <100.00%> (+1.96%) ⬆️
feature_engine/encoding/mean_encoding.py 100.00% <100.00%> (+4.76%) ⬆️
feature_engine/encoding/one_hot.py 100.00% <100.00%> (+4.76%) ⬆️
feature_engine/encoding/ordinal.py 97.22% <100.00%> (+0.44%) ⬆️
feature_engine/encoding/probability_ratio.py 90.38% <100.00%> (+0.80%) ⬆️
feature_engine/encoding/rare_label.py 100.00% <100.00%> (+6.12%) ⬆️
feature_engine/encoding/woe.py 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@solegalli solegalli mentioned this pull request Oct 13, 2022
11 tasks
@solegalli
solegalli merged commit 7338056 into main Oct 13, 2022
@solegalli
solegalli deleted the check_inversetransform branch October 13, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inverse transform functionality of encoders OrdinalEncoder could output -1 for unseen categories

1 participant