Skip to content

[BUG] Readme fix - #552

Merged
solegalli merged 5 commits into
feature-engine:mainfrom
glevv:readme-fix
Nov 7, 2022
Merged

[BUG] Readme fix#552
solegalli merged 5 commits into
feature-engine:mainfrom
glevv:readme-fix

Conversation

@glevv

@glevv glevv commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

It should fix broken conda badge.
It also should fix codecov badge for the whole project

@codecov

codecov Bot commented Nov 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #552 (5922906) into main (50cecc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          90       90           
  Lines        3480     3480           
  Branches      681      681           
=======================================
  Hits         3392     3392           
  Misses         32       32           
  Partials       56       56           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@glevv
glevv marked this pull request as ready for review November 5, 2022 19:16
@glevv glevv changed the title [WIP] Readme fix [BUG] Readme fix Nov 6, 2022
@solegalli
solegalli merged commit a00a4d7 into feature-engine:main Nov 7, 2022
@solegalli

Copy link
Copy Markdown
Collaborator

Thank you so much @glevv !!!

@glevv

glevv commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

When you click on the badge, in order for codecov to show coverage for the whole project you need to switch default branch from "master" (old) to "main" in codecov settings, I think.

@solegalli

Copy link
Copy Markdown
Collaborator

Done! Thank you!

@glevv

glevv commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

No problem, now everything is working as intended

@glevv
glevv deleted the readme-fix branch March 24, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants