Update fold default value for outlier class - #554
Closed
px39n wants to merge 12 commits into
Closed
Conversation
eg: OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) will raise error due to default fold is 3.
eg: OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) will raise error due to default fold is 3.
**This change is not necessary, but make this function more friendly.** Changed default value of fold to 0.05 when the capping_method='quantile', for other methods, keep the default as 3. Past : ``` OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) will raise error due to default fold is 3. ``` For now: ``` OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) Will work, ```
This reverts commit c5b6168.
Contributor
Author
|
Whats wrong with test_type :0 |
Collaborator
|
test_type errors have been fixed in #555 If you rebase main onto your feature branch, it should work now. I don't see the files with the changes. What happened? |
**This change is not necessary, but make this function more friendly.** Changed default value of fold to 0.05 when the capping_method='quantile', for other methods, keep the default as 3. Past : ``` OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) will raise error due to default fold is 3. ``` For now: ``` OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) Will work, ```
…tlier_default_fold_change
This reverts commit c5b6168.
This change is not necessary, but make this function more friendly. Changed default value of fold to 0.05 when the capping_method='quantile', for other methods, keep the default as 3. Past : OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) will raise error due to default fold is 3. For now: OutlierTrimmer(capping_method='quantile') OutlierTrimmer.fit(X) Will work,
…tlier_default_fold_change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is not necessary, but make this function more friendly.
Changed default value of fold to 0.05 when the capping_method='quantile', for other methods, keep the default as 3.
Past :
For now: