Skip to content

update circleci image and fix sklearn 1.2.0 release incurred errors - #575

Closed
solegalli wants to merge 19 commits into
mainfrom
update_circleci
Closed

update circleci image and fix sklearn 1.2.0 release incurred errors#575
solegalli wants to merge 19 commits into
mainfrom
update_circleci

Conversation

@solegalli

@solegalli solegalli commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

closes #574

Massive update to the API at the back of sklearn release of version 1.2.0

Make sure these changes make transformers compatible with sklearn 1.2.0. In short, I need to understand how the set_output() method works from within a pipeline and gridsearch and see if I need to add it to all transformers, in which case, it would most likely be in the TransfomerMixin.

See: scikit-learn-contrib/imbalanced-learn@43dde5d

@codecov

codecov Bot commented Dec 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #575 (44d3129) into main (3cd3bbb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   97.47%   97.49%   +0.01%     
==========================================
  Files          90       91       +1     
  Lines        3492     3506      +14     
  Branches      687      688       +1     
==========================================
+ Hits         3404     3418      +14     
  Misses         32       32              
  Partials       56       56              
Impacted Files Coverage Δ
...eature_engine/_base_transformers/base_numerical.py 100.00% <100.00%> (ø)
feature_engine/_base_transformers/mixins.py 100.00% <100.00%> (ø)
feature_engine/creation/base_creation.py 93.75% <100.00%> (ø)
feature_engine/datetime/datetime.py 100.00% <100.00%> (ø)
feature_engine/encoding/base_encoder.py 98.59% <100.00%> (ø)
feature_engine/imputation/base_imputer.py 100.00% <100.00%> (ø)
feature_engine/outliers/base_outlier.py 94.89% <100.00%> (ø)
feature_engine/preprocessing/match_columns.py 97.91% <100.00%> (ø)
feature_engine/selection/base_selector.py 100.00% <100.00%> (ø)
...meseries/forecasting/base_forecast_transformers.py 96.77% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@solegalli solegalli changed the title update circleci image update circleci image and fix sklearn 1.2.0 release incurred errors Dec 8, 2022
@solegalli solegalli mentioned this pull request Jan 10, 2023
@solegalli
solegalli deleted the update_circleci branch January 10, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circleci not working properly

1 participant