Skip to content

[MRG] add transformer for substraction of datetime variables - #632

Merged
solegalli merged 19 commits into
mainfrom
dt_subtraction
Mar 14, 2023
Merged

[MRG] add transformer for substraction of datetime variables#632
solegalli merged 19 commits into
mainfrom
dt_subtraction

Conversation

@solegalli

@solegalli solegalli commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

closes #486
closes #359
closes #330

  • add few more tests, ie non fitted error
  • finish user guide

@codecov

codecov Bot commented Mar 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #632 (e7ccd4c) into main (9db7124) will decrease coverage by 0.08%.
The diff coverage is 93.93%.

❗ Current head e7ccd4c differs from pull request most recent head 75cac5a. Consider uploading reports for the commit 75cac5a to get more accurate results

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   97.90%   97.83%   -0.08%     
==========================================
  Files          98       99       +1     
  Lines        3588     3653      +65     
  Branches      695      706      +11     
==========================================
+ Hits         3513     3574      +61     
- Misses         28       30       +2     
- Partials       47       49       +2     
Impacted Files Coverage Δ
feature_engine/datetime/datetime_subtraction.py 93.75% <93.75%> (ø)
feature_engine/datetime/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@solegalli solegalli changed the title add transformer for substraction of datetime variables [MRG] add transformer for substraction of datetime variables Mar 12, 2023
@solegalli

Copy link
Copy Markdown
Collaborator Author

Hey @glevv

If you have time, would you be able to have a quick look at this new class? maybe just class and tests and ignore the doc files?

that would be amazing :)

@solegalli
solegalli merged commit 3a09d7f into main Mar 14, 2023
@solegalli
solegalli deleted the dt_subtraction branch March 14, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New transformer to substract datetime variables, that is support timestamp subtraction

1 participant