return name of variables with 0s in denominator in woe encoder - #676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 97.91% 97.99% +0.07%
==========================================
Files 100 100
Lines 3748 3841 +93
Branches 726 754 +28
==========================================
+ Hits 3670 3764 +94
+ Misses 29 28 -1
Partials 49 49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey @glevv I am expanding the functionality of the WoE encoder to do 2 things:
Regarding 1: the error was there already. The improvement consists in letting users know which variables are the problematic Regarding 2: I think this defeats the point of the calculation, but I guess we leave this to the user. The implementation is different from category encoders because 1) category encoders adds the regularization to all categories, regardless of whether they have zero or not. Here we modify only those with 0. And 2) we replace the 0 with the fill value. Category encoders adds the regularization to both denominator and numerator) I would appreciate if you had 2 minutes to let me know what you think about the implementation, and if you can go over the code, even better. Thanks a lot! |
closes #672
closes #430
closes #56
and also
closes #673