add links to course and book in userguide-selection - #704

Merged

solegalli merged 21 commits into

feature-engine:mainfrom

Bestine:bestine-branch

Oct 19, 2023

Bestine commented Oct 18, 2023 •

edited by solegalli

Loading

Contributor

No description provided.


          More details to .rst files

0f65966

codecov Bot commented Oct 18, 2023 •

edited

Loading

Codecov Report

Merging #704 (9659028) into main (a819eb1) will not change coverage.
The diff coverage is n/a.

❗ Current head 9659028 differs from pull request most recent head ff0905a. Consider uploading reports for the commit ff0905a to get more accurate results

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         100      100           
  Lines        3877     3877           
  Branches      761      761           
=======================================
  Hits         3801     3801           
  Misses         28       28           
  Partials       48       48

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

solegalli reviewed

View reviewed changes

solegalli left a comment

Collaborator

Thank you for the initial PR. It's almost there. Please see my comments below and make sure to include the links to the resources.

Thank you!

docs/user_guide/selection/index.rst Outdated

               - `Feature Selection book <https://leanpub.com/feature-selection-in-machine-learning/>`_
               - `Train in data's blog <https://www.blog.trainindata.com/>`_
+              For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Please remove links from this file

docs/user_guide/selection/SmartCorrelatedSelection.rst

		All notebooks can be found in a `dedicated repository <https://github.com/feature-engine/feature-engine-examples>`_.

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

please don't live so much space between lines

docs/user_guide/selection/SelectByShuffling.rst Outdated

 -0.011595  0.012191  0.024991  0.022688
 -0.036385  0.003935  0.015596 -0.031988
+                  For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

please remove indentation

docs/user_guide/selection/DropFeatures.rst Outdated

               In this Kaggle kernel we feature 3 different end-to-end machine learning pipelines using
               :class:`DropFeatures()`:
+              For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

pleaase move these changes to after the kaggle notebook

Bestine Oct 18, 2023

Contributor Author

Okay, fine. Am following

Bestine added 3 commits

October 18, 2023 15:38


          Added more details on feature selection; books and online course

7ae94ce


          Remove unwanted links from the project

9b41e62


          Made Corrections

c57a615

solegalli reviewed

View reviewed changes

docs/user_guide/selection/RecursiveFeatureAddition.rst Outdated

 -0.036385  0.021872  0.003935 -0.031988
+              For more details about this and other feature selection methods check out these resources:
+              - `Feature selection for machine learning <https://www.trainindata.com/p/feature-selection-for-machine-learning>` _, online course.

solegalli Oct 18, 2023

Collaborator

Thank you for the modifications.

Small detail, there needs to be one line between the text and the bulletpoints, otherwise the documentation does not build properly. Please check how I put together text and bullets with links in the files you are modifying as inspiration.

solegalli reviewed

View reviewed changes

docs/user_guide/selection/DropConstantFeatures.rst

solegalli reviewed

View reviewed changes

docs/user_guide/selection/DropCorrelatedFeatures.rst

solegalli reviewed

View reviewed changes

docs/user_guide/selection/DropDuplicateFeatures.rst

solegalli reviewed

View reviewed changes

docs/user_guide/selection/DropFeatures.rst

solegalli reviewed

View reviewed changes

docs/user_guide/selection/DropHighPSIFeatures.rst


		All notebooks can be found in a `dedicated repository <https://github.com/feature-engine/feature-engine-examples>`_.

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/ProbeFeatureSelection.rst

               - `Kaggle Tips for Feature Engineering and Selection <https://www.youtube.com/watch?v=RtqtM1UJfZc&t=3150s>`_, by Gilberto Titericz.
               - `Feature Selection: Beyond feature importance? <https://www.kdnuggets.com/2019/10/feature-selection-beyond-feature-importance.html>`_, KDDNuggets.
+              For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/RecursiveFeatureAddition.rst

 -0.011595 -0.036656  0.012191  0.022688
 -0.036385  0.021872  0.003935 -0.031988
+              For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/RecursiveFeatureElimination.rst


		- `Recursive feature elimination with Python <https://www.blog.trainindata.com/recursive-feature-elimination-with-python/>`_

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/SelectByInformationValue.rst

-              or grouping rare categories with the RareLabelEncoder if they are categorical.

                
                    No newline at end of file
+              or grouping rare categories with the RareLabelEncoder if they are categorical.
+              For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/SelectByShuffling.rst

		4 -0.036385 0.003935 0.015596 -0.031988


		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/SelectBySingleFeaturePerformance.rst


		All notebooks can be found in a `dedicated repository <https://github.com/feature-engine/feature-engine-examples>`_.

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/SelectByTargetMeanPerformance.rst


		All notebooks can be found in a `dedicated repository <https://github.com/feature-engine/feature-engine-examples>`_.

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

solegalli reviewed

View reviewed changes

docs/user_guide/selection/SmartCorrelatedSelection.rst


		All notebooks can be found in a `dedicated repository <https://github.com/feature-engine/feature-engine-examples>`_.

		For more details about this and other feature selection methods check out these resources:

solegalli Oct 18, 2023

Collaborator

Suggested change

      
            For more details about this and other feature selection methods check out these resources:
          
            For more details about this and other feature selection methods check out these resources:

Bestine added 2 commits

October 18, 2023 17:27


          Edited the files as required

4ad44d3


          Removed unwanted characters after the lists

63f17e6

solegalli reviewed

View reviewed changes

solegalli left a comment

Collaborator

If you look at how the file it's rendered, you'll see that the links that you added show the word and the URL, whereas the links that are in the file, like for examplee Kaggle kernel, do not show the url, instead they appear linked. I think the problem is that there is a space between the final ` and the _. Could you please check?

Bestine added 7 commits

October 19, 2023 10:53


          Updated when testing links DropConstantFeatures.rst

991a1a3


          Update DropCorrelatedFeatures.rst

0054ace


          Update DropDuplicateFeatures.rst

0263e35


          Update DropFeatures.rst

70f2a2a


          Update DropHighPSIFeatures.rst

821f57a


          Update ProbeFeatureSelection.rst

16284d8


          Update RecursiveFeatureAddition.rst

b0c34cd

Bestine added 6 commits

October 19, 2023 12:00


          Update RecursiveFeatureElimination.rst

28b6a52


          Update SelectByInformationValue.rst

42220ad


          Update SelectByShuffling.rst

15b961d


          Update SelectBySingleFeaturePerformance.rst

a6b5c1c


          Update SelectByTargetMeanPerformance.rst


          Update SmartCorrelatedSelection.rst

57dcfaa

solegalli reviewed

View reviewed changes

docs/user_guide/selection/index.rst

               Additional Resources
               --------------------
-              More details about feature selection can be found in the following resources:

solegalli Oct 19, 2023

Collaborator

These lines were not the ones you added, they were there already. Could you please add them back?

solegalli added 2 commits

October 19, 2023 13:10


          fix index.rst


          Update index.rst

ff0905a

solegalli changed the title ~~More details about further learning to .rst files~~ add links to course and book in userguide-selection

solegalli merged commit 073a96a into feature-engine:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet