Feature Creation copy for API doc index.rst - #725
Conversation
There was a problem hiding this comment.
@Morgan-Sell this looks just great! Thank you so much!
I made a few suggestions (mostly capitalize Feature-engine). You can just accept them here and then pull the changes to your branch. Or can update your branch and push, as you wish.
The errors in the tests are due to pandas and sklearn new releases. But I fixed that yesterday. So if you pull the latest main version onto your main branch, then check out your seo branch and rebase main onto it, the tests should pass
This is almost ready to go! Thank you!
|
hola @solegalli, me alegro que te gustelo! I had to get creative, e.g., "real-world experimentation" ;) Would you like for all mentions of "Feature-engine" to be capitalized? I ask because you skipped over a few. Lmk and I'll revise the copy. Voy a comenzar escribir el texto de time series. Vamooossss ;) |
Yes please! Thank you! |
|
done! |
|
Could you please rebase main onto the feature branch to fix the tests? |
…eature-engine#721) * change implementation to numpy for speed * add sorted to make deterministic * improve coverage * create abstraction for finding correlated features * add attribute with dictionary * make initial edits of smart corr transformer * initial rearrangement of the smart corr functionality * refactor smart correlation selection * add test for single_feature_selection function * rename file * fix several bugs in smart correlation * expand and fix tests smart correlation * fix error version 1.4 sklearn * fix typos * minor text edits * fix pandas deprecation * fix errors in yeoohnson * fix style * update docs * update docs * fix variable type deprecation * fix all unrelated errors' * remove support for python 3.8 * comment out break with new sklearn version * add newer python versions to circleci tests' * change python images circleci * attempt to fix the correlation test error * add environments to tox ini * expand docs * add changelog * add changelog to index
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 98.16% 98.31% +0.15%
==========================================
Files 103 103
Lines 3930 3928 -2
Branches 771 764 -7
==========================================
+ Hits 3858 3862 +4
+ Misses 26 23 -3
+ Partials 46 43 -3 ☔ View full report in Codecov by Sentry. |
|
hola @solegalli, I added a toctree Sphinx at the bottom of the .rst file. Is that correct? Once we're good on the toctree, we're good to go! |
|
Hey @Morgan-Sell Something went wrong with rebase. I should see here only the files that you changed for this PR. But I see 29 files instead. Could you please check? |
|
@solegalli, I see what you're saying. Fortunately, I didn't perform major changes after rebasing. Is the best approach the following?
|
|
it sounds ok to me |
|
Hi @solegalli, I tried the above approach and I ended up with the same result. I followed the directions on feature-engine contribute docs, so I'm unsure what happened. However, will this be an issue when merging to feature-engine main? It seems somehow I merged I know it isn't ideal, but I believe/hope it will be fine in the end. |
2 participants
Wrote copy for creation module API Docs index.rst. Copy achieved A++ content grade.