Skip to content

add tz aware columns to variable handling functions - #811

Merged
solegalli merged 3 commits into
feature-engine:mainfrom
jccalvojackson:tz_aware_transform
Sep 10, 2024
Merged

add tz aware columns to variable handling functions#811
solegalli merged 3 commits into
feature-engine:mainfrom
jccalvojackson:tz_aware_transform

Conversation

@jccalvojackson

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Sep 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (3e7b50e) to head (8810d2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         107      108    +1     
  Lines        4332     4335    +3     
  Branches      857      857           
=======================================
+ Hits         4245     4248    +3     
  Misses         54       54           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread feature_engine/variable_handling/check_variables.py Outdated

@solegalli solegalli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jccalvojackson !

This one is good to go. Could you check the indentation suggestion that I make below?

Cheers!

Co-authored-by: Soledad Galli <solegalli@protonmail.com>
@solegalli solegalli changed the title tz aware columns support add tz aware columns to variable handling functions Sep 10, 2024
@solegalli
solegalli merged commit 3dcc864 into feature-engine:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants