Skip to content

add MRMR feature selector - #817

Merged
solegalli merged 14 commits into
mainfrom
mrmr
Oct 31, 2024
Merged

add MRMR feature selector#817
solegalli merged 14 commits into
mainfrom
mrmr

Conversation

@solegalli

Copy link
Copy Markdown
Collaborator

closes #495

@codecov

codecov Bot commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 99.22481% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (3dcc864) to head (c2042e8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
feature_engine/selection/mrmr.py 99.21% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
+ Coverage   97.99%   98.02%   +0.03%     
==========================================
  Files         108      109       +1     
  Lines        4335     4464     +129     
  Branches      857      727     -130     
==========================================
+ Hits         4248     4376     +128     
  Misses         54       54              
- Partials       33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@solegalli

Copy link
Copy Markdown
Collaborator Author

Hey @MetroCat69 I made a start with this class, but I didn't implement the logic correctly. I didn't realize that it needs to be iterative. Wondered if you would like to step in and fix the logic? that would be great help!

@solegalli
solegalli merged commit ee6a31b into main Oct 31, 2024
@solegalli
solegalli deleted the mrmr branch October 31, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new transformer: feature selection using mrmr

1 participant