make wrappers module compatible - #835
Merged
solegalli merged 3 commits intoJan 21, 2025
Merged
Conversation
Merged
5 tasks
Collaborator
|
Thank you! |
solegalli
added a commit
that referenced
this pull request
Jan 22, 2025
* expand parametrize with tests to all current classes * reorder creation imports, remove estimator checks * reorder inheritance datetime module * makes module creation compatible with sklearn 1.6 * improves code style * add sklearn tag to dateimte transformer * makes discretization compatible with sklearn 1.6 * makes encoding module compatible with sklearn 1.6 * make imputation module compatible * make outlier module compatible * make provisory fix for prediction module * make preprocessing module compatible * make transformation module compatible with sklearn_tags (#836) * make transformation module compatible * Remove positive only tag from more_tags * Revert adding input tag positive only * make time_series module compatible (#834) * make time_series module compatible * fix typo * refactor test code * make wrappers module compatible (#835) * make wrappers module compatible * Add missing new line * Sort imports in test file * make selection module compatible * fix style in feature engine module * fix style in tests module * fix mypy check * add tags to woe * fix style * add test for sklearn 1.5 * remove circleci update * make some rewording on tags * remove redundant tag, reorder inheritance * fix style * Update tests/test_creation/test_check_estimator_creation.py Co-authored-by: Claudio Salvatore Arcidiacono <22871978+ClaudioSalvatoreArcidiacono@users.noreply.github.com> * Update tests/test_discretisation/test_check_estimator_discretisers.py Co-authored-by: Claudio Salvatore Arcidiacono <22871978+ClaudioSalvatoreArcidiacono@users.noreply.github.com> * Update tests/test_encoding/test_check_estimator_encoders.py Co-authored-by: Claudio Salvatore Arcidiacono <22871978+ClaudioSalvatoreArcidiacono@users.noreply.github.com> * Update tests/test_imputation/test_check_estimator_imputers.py Co-authored-by: Claudio Salvatore Arcidiacono <22871978+ClaudioSalvatoreArcidiacono@users.noreply.github.com> * fix style: * refactor check creation * add todo * refactor check estimator selection * remove woe from testing * remove dup code --------- Co-authored-by: Claudio Salvatore Arcidiacono <22871978+ClaudioSalvatoreArcidiacono@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #831 for the wrappers module.