Skip to content

fix information value selector tests - #867

Merged
solegalli merged 2 commits into
mainfrom
fix_tags_ivselector
Jul 5, 2025
Merged

fix information value selector tests#867
solegalli merged 2 commits into
mainfrom
fix_tags_ivselector

Conversation

@solegalli

Copy link
Copy Markdown
Collaborator

Added the sklearn tags attribute as required by sklearn version 1.7.0

The tests now fail, because this transformer requires the target to be binary. However, to enforce this, it needs to inherit from ClassifierMixin, which is not possible because our transformer is a transformer and not a classifier. So I had to de-activate the tests for this transformer for versions 1.7.0 and onwards.

@codecov

codecov Bot commented Jul 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (ead2457) to head (b17273d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         111      111           
  Lines        4643     4646    +3     
  Branches      739      739           
=======================================
+ Hits         4552     4555    +3     
  Misses         56       56           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@solegalli
solegalli merged commit b2b4f68 into main Jul 5, 2025
11 checks passed
@solegalli
solegalli deleted the fix_tags_ivselector branch July 5, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant