Fix a bug where fedify inbox had always responded with empty payloads with tunneling

[dahlia]

The fedify inbox had always responded with empty payloads with tunneling. It was due to the fetch() function which was hard-coded to return new Response() in any condition.

[gemini-code-assist]

Summary of Changes

Hello @dahlia, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the fedify inbox command that prevented it from returning any data when tunneling was active. The core of the fix involves a significant update to the temporary server's request handling mechanism, ensuring that all tunneled requests are correctly processed over HTTPS and receive their expected responses. This change enhances the reliability and functionality of the fedify inbox command in tunneled environments.

Highlights

• Bug Fix: Empty Payloads with Tunneling: Resolved an issue where the fedify inbox command, when used with tunneling, would consistently return empty payloads due to an incorrectly implemented fetch() function.
• Corrected fetch Handler Logic: The temporary server's fetch handler has been refactored to properly process and forward requests. It now reconstructs incoming requests to use the https: protocol and then executes the actual network fetch operation, ensuring data is correctly retrieved.
• Silent Server Operation: Added silent: true to the serve options for the temporary server instances, which will reduce verbose logging output during operation.
• Enforced HTTPS Protocol: Explicitly configured the tunneled server to use the https protocol, aligning with the re-written request URLs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[dahlia]

It's the cause.

[gemini-code-assist]

Code Review

This pull request fixes a critical bug where the fedify inbox command would return empty responses when using tunneling. The issue was a hardcoded empty Response. The fix correctly forwards the request to the handler after modifying its URL protocol to HTTPS. My review includes suggestions to improve code maintainability by avoiding parameter reassignment and by adding a comment to clarify some runtime-specific logic.

[sij411]

Checked the bug fixed.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/cli/src/tempserver.ts	0.00%	28 Missing ⚠️

Files with missing lines	Coverage Δ
packages/cli/src/tempserver.ts	5.63% <0.00%> (-0.25%)	⬇️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.