Skip to content

Conversation

@moreal
Copy link
Contributor

@moreal moreal commented Jan 27, 2026

Summary

This pull request lets each package exclude non-essential files (e.g., tsdown.config.ts, scripts/, src/testing/*) when publishing to JSR.

https://jsr.io/@fedify/fedify/1.10.2
image

Related issue

I couldn't find related issues when searching with:

  • "JSR"
  • "unnecessary"
  • label:component/ci

Changes

  • Let @fedify/amqp exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/elysia exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/express exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/fastify exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/h3 exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/hono exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/koa exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/lint exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/postgres exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/redis exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/relay exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/sqlite exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/sveltekit exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/testing exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/vocab-runtime exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/vocab-tools exclude tsdown.config.ts when publishing to JSR.
  • Let @fedify/cfworkers exclude tsdown.config.ts, vitest.config.ts and wrangler.jsonc when publishing to JSR.
  • Let @fedify/cli exclude tsdown.config.ts and scripts/ when publishing to JSR.
  • Let @fedify/fedify exclude tsdown.config.ts, scripts/ and wrangler.toml when publishing to JSR.
  • Let @fedify/vocab exclude tsdown.config.ts and **/*.test.ts when publishing to JSR.
  • Let @fedify/webfinger exclude tsdown.config.ts and **/*.test.ts when publishing to JSR.

Benefits

While the reduction in file size might not be huge, it means library users won't have to download unnecessary files.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run mise test on your machine?

@issues-auto-labeler issues-auto-labeler bot added component/build Build system and packaging component/cli CLI tools related labels Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @moreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the publishing process for various packages by configuring them to exclude non-essential files when published to JSR. The primary goal is to optimize package size, ensuring that consumers only download necessary components, thereby improving efficiency and reducing bandwidth usage for library users.

Highlights

  • @fedify/amqp: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/elysia: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/express: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/fastify: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/h3: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/hono: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/koa: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/lint: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/postgres: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/redis: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/relay: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/sqlite: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/sveltekit: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/testing: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/vocab-runtime: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/vocab-tools: Exclude tsdown.config.ts when publishing to JSR.
  • @fedify/cfworkers: Exclude tsdown.config.ts, vitest.config.ts and wrangler.jsonc when publishing to JSR.
  • @fedify/cli: Exclude tsdown.config.ts and scripts/ when publishing to JSR.
  • @fedify/fedify: Exclude tsdown.config.ts, scripts/ and wrangler.toml when publishing to JSR.
  • @fedify/vocab: Exclude tsdown.config.ts and **/*.test.ts when publishing to JSR.
  • @fedify/webfinger: Exclude tsdown.config.ts and **/*.test.ts when publishing to JSR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes a valuable improvement by excluding non-essential development files from the published JSR packages, reducing their size. The changes are consistent across most packages. I've found one minor omission for the @fedify/vocab package where the scripts directory could also be excluded, similar to how it's handled for other packages in this PR. Other than that, the changes look great.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@moreal moreal force-pushed the exclude-non-essentials-from-jsr-publish branch from b068175 to a2d5860 Compare January 27, 2026 08:11
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@moreal moreal marked this pull request as ready for review January 27, 2026 08:15
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dahlia dahlia merged commit a6f6fa3 into fedify-dev:main Jan 27, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/build Build system and packaging component/cli CLI tools related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants