-
-
Notifications
You must be signed in to change notification settings - Fork 89
Exclude non-essential files from JSR publishing #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude non-essential files from JSR publishing #545
Conversation
Summary of ChangesHello @moreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the publishing process for various packages by configuring them to exclude non-essential files when published to JSR. The primary goal is to optimize package size, ensuring that consumers only download necessary components, thereby improving efficiency and reducing bandwidth usage for library users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes a valuable improvement by excluding non-essential development files from the published JSR packages, reducing their size. The changes are consistent across most packages. I've found one minor omission for the @fedify/vocab package where the scripts directory could also be excluded, similar to how it's handled for other packages in this PR. Other than that, the changes look great.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
b068175 to
a2d5860
Compare
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
This pull request lets each package exclude non-essential files (e.g.,
tsdown.config.ts,scripts/,src/testing/*) when publishing to JSR.https://jsr.io/@fedify/fedify/1.10.2

Related issue
I couldn't find related issues when searching with:
"JSR""unnecessary"label:component/ciChanges
@fedify/amqpexcludetsdown.config.tswhen publishing to JSR.@fedify/elysiaexcludetsdown.config.tswhen publishing to JSR.@fedify/expressexcludetsdown.config.tswhen publishing to JSR.@fedify/fastifyexcludetsdown.config.tswhen publishing to JSR.@fedify/h3excludetsdown.config.tswhen publishing to JSR.@fedify/honoexcludetsdown.config.tswhen publishing to JSR.@fedify/koaexcludetsdown.config.tswhen publishing to JSR.@fedify/lintexcludetsdown.config.tswhen publishing to JSR.@fedify/postgresexcludetsdown.config.tswhen publishing to JSR.@fedify/redisexcludetsdown.config.tswhen publishing to JSR.@fedify/relayexcludetsdown.config.tswhen publishing to JSR.@fedify/sqliteexcludetsdown.config.tswhen publishing to JSR.@fedify/sveltekitexcludetsdown.config.tswhen publishing to JSR.@fedify/testingexcludetsdown.config.tswhen publishing to JSR.@fedify/vocab-runtimeexcludetsdown.config.tswhen publishing to JSR.@fedify/vocab-toolsexcludetsdown.config.tswhen publishing to JSR.@fedify/cfworkersexcludetsdown.config.ts,vitest.config.tsandwrangler.jsoncwhen publishing to JSR.@fedify/cliexcludetsdown.config.tsandscripts/when publishing to JSR.@fedify/fedifyexcludetsdown.config.ts,scripts/andwrangler.tomlwhen publishing to JSR.@fedify/vocabexcludetsdown.config.tsand**/*.test.tswhen publishing to JSR.@fedify/webfingerexcludetsdown.config.tsand**/*.test.tswhen publishing to JSR.Benefits
While the reduction in file size might not be huge, it means library users won't have to download unnecessary files.
Checklist
mise teston your machine?