Upgrade Deno from 2.6.10 to 2.7.6#636
Conversation
Deno 2.7.5 introduced a regression in TTY stream and readline handling that caused consecutive @inquirer/prompts select() calls to hang on the second prompt (denoland/deno#32782). This affected `fedify init` when built with `deno compile` (e.g., the Homebrew distribution). Deno 2.7.6 fixes this upstream issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical regression affecting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the Deno runtime from version 2.6.10 to 2.7.6. The change is applied consistently in mise.toml and the GitHub Actions workflow file .github/actions/setup-deno/action.yaml. The reason for the upgrade is clearly stated in the description, addressing a regression in a previous Deno version. The changes are correct and appropriate.
Deno 2.7.6 updated its built-in Temporal API type definitions, which diverged from @js-temporal/polyfill@0.5.1's types (Duration.sign return type, Duration.round() parameter signatures). The test files in postgres and sqlite packages explicitly typed the Temporal variable with the polyfill's type, causing TS2322 errors when assigning globalThis.Temporal. Also replace "deno.temporal" with "esnext.temporal" in the Fresh example's compilerOptions.lib, since "deno.temporal" is not a recognized lib name in Deno 2.7.6's TypeScript. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
@inquirer/promptsselect()calls to hang on the second prompt (Consecutive @inquirer/promptsselect()calls hang on second prompt since 2.7.5 denoland/deno#32782)fedify initwhen built withdeno compile(e.g., the Homebrew distribution), as reported in@fedify/clidoesn't work well afterfedify initdepends on different download source #623Test plan
mise installinstalls Deno 2.7.6 successfullymise run check) pass