Revive removed fedify init options#638
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully revives the bare-bones web framework, in-memory key-value store, and in-process message queue options for fedify init. The changes include updating documentation, introducing new configuration JSON files for KV stores and message queues, and adding corresponding bare-bones templates for Deno, Bun, and Node.js. The dynamic loading of KV and MQ options from JSON files is a good architectural improvement, centralizing configuration. Additionally, the test suite has been made more robust by incorporating default port fallbacks.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
Revive removed
fedify initoptions.In-memoryin Message Queue.In-processin KV Stores.Bare-bonesin Web Frameworks.Related issue
fedify initoptions #632Changes
packages/init/srcBenefits
Now users can use the options again.
Checklist
Did you write a regression test to reproduce the bug (if it's a bug fix)?Did you write some tests for this change (if it's a new feature)?mise teston your machine?Additional notes
In version 2.1, since the
webframeworks.tsfile is modularized by framework, some modifications are required.