This repository was archived by the owner on Apr 30, 2020. It is now read-only.
Shebang check update #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Feb 8, 2018
| import pytest | ||
|
|
||
| from taskotron_python_versions.python_usage import file_contains | ||
| from taskotron_python_versions.common import file_contains |
Member
There was a problem hiding this comment.
Maybe the test should move to test_common.py?
Collaborator
Author
There was a problem hiding this comment.
Hm, we do not yet have test_common.py, so I will just rename this file.
Member
There was a problem hiding this comment.
Makes sense if it only tests that function. Thanks
hroncok
approved these changes
Feb 15, 2018
The function is going to be needed by shebang check as well to work with log file.
… mangling in build logs Keep the ambiguous shebangs check in place, in case brp script is disabled, but also check the build logs for the warning generated when the shebangs are automatically mangled. Fail the shebang check in both cases.
…angs check Reuse python-bucky fixture with the latest version for the check, as it did not change much, except that naming scheme was fixed, but we have other fixtures for naming scheme check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unversioned_shebangs task to also check for automatic shebangs mangling in build logs (#42 )
Keep the ambiguous shebangs check in place, in case brp script is disabled, but also check the build logs for the warning generated when the shebangs are automatically mangled. Fail the shebang check in both
cases.