"Unable to open /etc/scl/prefixes/" error after running f19.rb

[jrafanie]

Running f19.rb, changes the gem install convention to gem_install but doesn't deal or warn about quoting of the scl enable line. Perhaps this script is not really applicable to SCL but I thought it was worth asking about. Perhaps even linking to this issue is enough for anyone else who runs into this.

Before:

mkdir -p .%{gem_dir}        
 %{?scl:scl enable %{scl} "}
gem install \       +%gem_install -n %{SOURCE0}
    -V \        
    --local \       
    --install-dir $(pwd)/%{gem_dir} \       
    --force \       
    --rdoc \        
    %{SOURCE0}      
 %{?scl:"}

After f19.rb, see commit:

%{?scl:scl enable %{scl} "}
%gem_install -n %{SOURCE0}
%{?scl:"}        %{?scl:"}

This causes what appears to be a quoting issue:

Fixes this error:
+ scl enable ruby200 '
mkdir -p ./opt/rh/ruby200/root/usr/share/gems
CONFIGURE_ARGS=--with-cflags=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' ' gem install         -V         --local         --install-dir ./opt/rh/ruby200/root
'
Unable to open /etc/scl/prefixes/
mkdir -p ./opt/rh/ruby200/root/usr/share/gems

The fix was to clean up the quoting of the scl enable string to not use quotes and instead a heredoc:
Before:

%{?scl:scl enable %{scl} "}
%gem_install -n %{SOURCE0}
%{?scl:"}       

After(fixed), see commit

%{?scl:scl enable %scl - << \EOF}
 %gem_install -n %{SOURCE0}
%{?scl:EOF}

See full PR: ManageIQ/srpms#1

[voxik]

You are right, this script was never intended to be run on SCL package, although it might provide some inspiration. Thanks for providing reference.

If I may suggest, everybody should first convert the %{?scl:scl enable %{scl} "} to %{?scl:scl enable %scl - << \EOF}. The later is preferred way for more recent SCLs. May be another simple migration script might help with this task?

[jrafanie]

@voxik Great, yeah, I'd assume with names like f19 and f21, scl isn't at all the intention. I believe the non-heredoc scl enable syntax was borrowed from other scl packages back in early 2013. So, are there scripts that mass convert scl packages for similar changes in conventions, much like your f19 and f21 do for non-scl ruby packages on fedora? I'd like to make sure we abide by any scl changes in packaging guidelines. Thanks again!

[voxik]

spec2scl was always canonical tool for conversion from non-scl to scl packages. However, I have not idea how it copes with conversion of scl packages to scl packages. But that is the way I would pursue.